Tag Ports Created By CAPO Based on Network or Subnet Attached #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ubnet they are attached to
Author
|
/assign @adduarte |
Author
|
As per offline convo with @adduarte, I added a function to ensure users don't mistakenly duplicate tags for ports, as well as a set of tests to check it. Note that list order is not preserved, but it does not matter in this case. |
Author
|
/retest |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fedosin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
pierreprinetti
pushed a commit
to shiftstack/cluster-api-provider-openstack
that referenced
this pull request
Apr 22, 2024
fix incorrect path description, in future it may corrupt scripting arch. Close openshift#166
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives users the ability to tag the ports CAPO creates based on the network or subnet they are attached to. Some Usage patterns in the ProviderSpec are as follows:
tag1: all resources created by CAPO
tag2: all ports attached to network net1 created by CAPO
tag3: all ports attached to subnet snet1 created by CAPO
tag4: all ports attached to subnet snet2 created by CAPO
Fixes: OSASINFRA-2348