Skip to content

Conversation

@mandre
Copy link
Member

@mandre mandre commented Feb 1, 2021

Bug reported against CAPO should be filled under Cloud Compute -> OpenStack Provider.

Bug reported against CAPO should be filled under `Cloud Compute ->
OpenStack Provider`.
@mandre mandre requested review from pierreprinetti and removed request for adduarte and mdbooth February 1, 2021 07:32
@pierreprinetti
Copy link
Member

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2021
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@mandre
Copy link
Member Author

mandre commented Feb 1, 2021

/hold until master opens

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 1, 2021
Copy link
Member Author

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2021
@mandre
Copy link
Member Author

mandre commented Feb 9, 2021

/retest

@openshift-merge-robot openshift-merge-robot merged commit b9656d2 into openshift:master Feb 9, 2021
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
Currently after token expires, all further requests to OpenStack API
fail because of auth error. With this flag gophercloud will try to
recreate token on receiving 401 error from API.

Fixes: openshift#132
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants