Adds scaling annotations to machineset #133

adduarte · 2020-10-08T15:07:40Z

Adds mchineset controller.
The controller adds the diskKey, cpuKey, and memoryKey annotataions.
The annotations are required for autoscaling

openshift-ci-robot · 2020-10-14T05:57:53Z

@adduarte: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/gofmt	`59ff428`	link	`/test gofmt`
ci/prow/unit	`59ff428`	link	`/test unit`
ci/prow/images	`59ff428`	link	`/test images`
ci/prow/e2e-openstack	`59ff428`	link	`/test e2e-openstack`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

cmd/manager/main.go

pkg/cloud/openstack/machineset/controller.go

pkg/cloud/openstack/machineset/controller_test.go

pkg/cloud/openstack/machineset/controller_suite_test.go

adduarte · 2020-10-23T14:32:45Z

/approved

adduarte · 2020-10-26T20:43:44Z

/approved

EmilienM

Some nits but otherwise it looks good to me; however I don't feel confident enough yet to approve it, there are a lot if internals that I need to learn before.

hack/ci-test.sh

cmd/manager/main.go

pkg/cloud/openstack/machineset/cache.go

pkg/cloud/openstack/machineset/controller_test.go

pkg/cloud/openstack/machineset/cache.go

iamemilio · 2020-10-28T19:33:02Z

I think it would be very valuable to add a unit test for the cache.go library. Especially because it is async

The unit tests dont need to be too crazy, we just want to test:

the staled and failure timeouts are respected
getFlavorInfo() is thread safe
Failing to find a flavor nil's the pointer in the cache
our base case: returns flavor info when in cache or queries openstack

config/crds/machineset.openshift.io.crd.yaml

pkg/cloud/openstack/machineset/controller_suite_test.go

see inline comment.

Adds mchineset controller. The controller adds the cpuKey and memoryKey annotataions. The annotations are required for autoscaling

adduarte · 2020-11-11T19:13:48Z

/test e2e-openstack

iamemilio · 2020-11-11T22:50:56Z

/lgtm

adduarte · 2020-11-13T17:38:07Z

/lgtm
/approve

(just making it explicit :) )

openshift-ci-robot · 2020-11-13T17:38:08Z

@adduarte: you cannot LGTM your own PR.

Details

In response to this:

/lgtm
/approve

(just making it explicit :) )

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-11-13T17:38:16Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adduarte

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [adduarte]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

adduarte · 2020-11-16T04:02:04Z

/test e2e-openstack

Previously I forgot to add the cloud.conf to nodes. To rectify this mistake, I made the following changes: * Write the cloud.conf on the nodes. * Write a kubeadm join configuration. * Make kubeadm join using this configuration.

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2020

openshift-ci-robot requested review from Fedosin and mandre October 8, 2020 15:07

adduarte force-pushed the machineset_annotation_controller branch from 4845ecc to 59ff428 Compare October 14, 2020 05:52

adduarte self-assigned this Oct 15, 2020

adduarte requested review from iamemilio and pierreprinetti October 15, 2020 18:50

iamemilio reviewed Oct 20, 2020

View reviewed changes

cmd/manager/main.go Show resolved Hide resolved

iamemilio reviewed Oct 20, 2020

View reviewed changes

pkg/cloud/openstack/machineset/controller.go Outdated Show resolved Hide resolved

iamemilio reviewed Oct 20, 2020

View reviewed changes

pkg/cloud/openstack/machineset/controller_test.go Show resolved Hide resolved

adduarte force-pushed the machineset_annotation_controller branch from 59ff428 to a4e8b04 Compare October 22, 2020 06:34

adduarte commented Oct 22, 2020

View reviewed changes

pkg/cloud/openstack/machineset/controller_suite_test.go Show resolved Hide resolved

adduarte force-pushed the machineset_annotation_controller branch 3 times, most recently from 7428861 to a7c831d Compare October 23, 2020 07:30

adduarte changed the title ~~[WIP] Adds scaling annotations to machineset~~ Adds scaling annotations to machineset Oct 23, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 23, 2020

adduarte force-pushed the machineset_annotation_controller branch 2 times, most recently from dbbb61f to 51a765d Compare October 23, 2020 14:43

adduarte requested a review from iamemilio October 23, 2020 14:46

openshift deleted a comment from openshift-ci-robot Oct 26, 2020

EmilienM reviewed Oct 27, 2020

View reviewed changes

hack/ci-test.sh Show resolved Hide resolved

cmd/manager/main.go Outdated Show resolved Hide resolved

pkg/cloud/openstack/machineset/cache.go Show resolved Hide resolved

iamemilio reviewed Oct 28, 2020

View reviewed changes

pkg/cloud/openstack/machineset/controller_test.go Outdated Show resolved Hide resolved

iamemilio reviewed Oct 28, 2020

View reviewed changes

pkg/cloud/openstack/machineset/cache.go Outdated Show resolved Hide resolved

Fedosin previously requested changes Oct 30, 2020

View reviewed changes

config/crds/machineset.openshift.io.crd.yaml Show resolved Hide resolved

adduarte commented Nov 2, 2020

View reviewed changes

pkg/cloud/openstack/machineset/controller_suite_test.go Outdated Show resolved Hide resolved

adduarte force-pushed the machineset_annotation_controller branch from 51a765d to ba9570f Compare November 3, 2020 03:11

adduarte requested review from Fedosin and iamemilio November 3, 2020 03:12

adduarte force-pushed the machineset_annotation_controller branch from ba9570f to e53630e Compare November 4, 2020 08:14

adduarte force-pushed the machineset_annotation_controller branch 2 times, most recently from 90d00a9 to 247de3b Compare November 11, 2020 09:54

Adds scaling annotations to machineset

eda781a

Adds mchineset controller. The controller adds the cpuKey and memoryKey annotataions. The annotations are required for autoscaling

adduarte force-pushed the machineset_annotation_controller branch from 247de3b to eda781a Compare November 11, 2020 10:08

openshift-ci-robot assigned iamemilio Nov 11, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2020

openshift-merge-robot merged commit 155384b into openshift:master Nov 16, 2020

pierreprinetti deleted the machineset_annotation_controller branch December 5, 2020 22:41

pierreprinetti mentioned this pull request Dec 9, 2020

openstack: Enable scale-to-zero testing openshift/cluster-api-actuator-pkg#191

Merged

EmilienM mentioned this pull request Jan 31, 2023

Manual rebase on upstream #252

Closed

Adds scaling annotations to machineset #133

Adds scaling annotations to machineset #133

Uh oh!

Conversation

adduarte commented Oct 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Oct 14, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

adduarte commented Oct 23, 2020

Uh oh!

adduarte commented Oct 26, 2020

Uh oh!

EmilienM left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iamemilio commented Oct 28, 2020

Uh oh!

Uh oh!

Uh oh!

adduarte commented Nov 11, 2020

Uh oh!

iamemilio commented Nov 11, 2020

Uh oh!

adduarte commented Nov 13, 2020

Uh oh!

openshift-ci-robot commented Nov 13, 2020

Uh oh!

openshift-ci-robot commented Nov 13, 2020

Uh oh!

adduarte commented Nov 16, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

adduarte commented Oct 8, 2020 •

edited

Loading