Skip to content

Fix vendoring #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Oct 6, 2020
Merged

Fix vendoring #127

openshift-merge-robot merged 1 commit into from
Oct 6, 2020

Conversation

@pierreprinetti
Copy link
Member

@pierreprinetti pierreprinetti commented Sep 28, 2020

One file in a vendored folder matched an exclude rule in .gitignore.

@pierreprinetti
Fix vendoring
48d6f1a 
One file in a vendored folder matched an exclude rule in `.gitignore`.
mandre
mandre reviewed Sep 28, 2020
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a follow-up to #123? If so we can probably re-use the same bz. Otherwise we'll need to create one.

@pierreprinetti
Copy link
Member Author

pierreprinetti commented Sep 29, 2020

Is this a follow-up to #123

Not a follow-up of that one. I just realised that go mod vendor && git clean -fdxn on a clean master working directory would report one vendored file. While this can create issues to dependency checksumming, it's not affecting functionality AFAICS.

Do you think we should merge before master opens?

@pierreprinetti
Copy link
Member Author

pierreprinetti commented Sep 29, 2020

/retest

@mandre
Copy link
Member

mandre commented Sep 30, 2020

If it's not affecting functionality, this can wait until master opens on Fri.

mandre
mandre reviewed Oct 5, 2020
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 5, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2020
@mandre
Copy link
Member

mandre commented Oct 5, 2020

/retest

@openshift-bot
Copy link

openshift-bot commented Oct 5, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@pierreprinetti
Copy link
Member Author

pierreprinetti commented Oct 5, 2020

/retest

@openshift-bot
Copy link

openshift-bot commented Oct 5, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

14 similar comments
@openshift-bot
Copy link

openshift-bot commented Oct 5, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Oct 5, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Oct 5, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Oct 5, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Oct 5, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Oct 5, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Oct 5, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Oct 5, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Oct 5, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Oct 5, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Oct 5, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Oct 5, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Oct 5, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Oct 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 44dd3da into openshift:master Oct 6, 2020
@pierreprinetti pierreprinetti deleted the fix_vendoring branch October 6, 2020 04:45
@EmilienM EmilienM mentioned this pull request Jan 31, 2023
Closed
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
@scruplelesswizard @pierreprinetti
Update Dependencies (openshift#127)
82b30e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mandre mandre mandre left review comments

@adduarte adduarte Awaiting requested review from adduarte

@Fedosin Fedosin Awaiting requested review from Fedosin

Assignees

@mandre mandre

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pierreprinetti @mandre @openshift-ci-robot @openshift-bot @openshift-merge-robot