Skip to content

Conversation

@elmiko
Copy link

@elmiko elmiko commented Aug 27, 2020

What this PR does / why we need it:
This change backports the leader election mechanism to the 4.5 branch by cherry-picking the following commits:

2fe5ec9
9c64f48

Which issue(s) this PR fixes
Bugzilla 1864352

Danil-Grigorev and others added 2 commits August 27, 2020 15:09
Prevent machine controllers from writing in etcd at idle too often by
setting 120s lease, 20s retry and 110s deadline on all renewals. Higher
values cause tests to flake.
@openshift-ci-robot
Copy link

@elmiko: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Update leader election/release 4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elmiko
Copy link
Author

elmiko commented Aug 27, 2020

/retitle Bug 1864352: Update leader election for release 4.5

@openshift-ci-robot openshift-ci-robot changed the title Update leader election/release 4.5 Bug 1864352: Update leader election for release 4.5 Aug 27, 2020
@openshift-ci-robot
Copy link

@elmiko: This pull request references Bugzilla bug 1864352, which is invalid:

  • expected dependent Bugzilla bug 1861896 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1864352: Update leader election for release 4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 27, 2020
@pierreprinetti
Copy link
Member

/retest

2 similar comments
@pierreprinetti
Copy link
Member

/retest

@pierreprinetti
Copy link
Member

/retest

@mandre
Copy link
Member

mandre commented Sep 8, 2020

/bugzilla refresh
/retest
/approve

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 8, 2020
@openshift-ci-robot
Copy link

@mandre: This pull request references Bugzilla bug 1864352, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1861896 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1861896 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents
Details

In response to this:

/bugzilla refresh
/retest
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 8, 2020
@Danil-Grigorev
Copy link

@pierreprinetti @mandre PTAL, still need lgtm
/lgtm

@openshift-ci-robot
Copy link

@Danil-Grigorev: changing LGTM is restricted to collaborators

Details

In response to this:

@pierreprinetti @mandre PTAL, still need lgtm
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Danil-Grigorev, elmiko, mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mandre
Copy link
Member

mandre commented Sep 9, 2020

/test e2e-openstack

@markmc markmc added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. labels Sep 17, 2020
@markmc
Copy link

markmc commented Sep 17, 2020

Already approved for other platforms. Seems justified to avoid nasty failure scenario.

@openshift-merge-robot openshift-merge-robot merged commit f6733e6 into openshift:release-4.5 Sep 17, 2020
@openshift-ci-robot
Copy link

@elmiko: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1864352 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 1864352: Update leader election for release 4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants