Skip to content

Add liveness/readiness probes #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jun 22, 2020
Merged

Add liveness/readiness probes #105

openshift-merge-robot merged 1 commit into from
Jun 22, 2020

Conversation

@Danil-Grigorev
Copy link

@Danil-Grigorev Danil-Grigorev commented Jun 19, 2020

Close #104

@enxebre
Copy link
Member

enxebre commented Jun 19, 2020

/lgtm
needs to merge this to not be broken by openshift/machine-api-operator#602 (comment)

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 19, 2020

@enxebre: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm
needs to merge this to not be broken by openshift/machine-api-operator#602 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti
Copy link
Member

pierreprinetti commented Jun 19, 2020

/retest

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2020
@pierreprinetti
Copy link
Member

pierreprinetti commented Jun 22, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 22, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Danil-Grigorev, enxebre, pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9759360 into openshift:master Jun 22, 2020
@Danil-Grigorev Danil-Grigorev mentioned this pull request Jun 23, 2020
Merged
@EmilienM EmilienM mentioned this pull request Jan 31, 2023
Closed
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
@hidekazuna @pierreprinetti
Fix README.md (openshift#105)
b6975c2 
* Fix README.md

Required option --provider-os was added to generate-yaml.sh in openshift#90.
This patch fixes Cluster Creation section in README.md.

* Apply suggestions from code review

Co-Authored-By: hidekazuna <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adduarte adduarte Awaiting requested review from adduarte

@Fedosin Fedosin Awaiting requested review from Fedosin

1 more reviewer

@pierreprinetti pierreprinetti pierreprinetti approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pierreprinetti pierreprinetti

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add liveness/readiness probes

5 participants

@Danil-Grigorev @enxebre @openshift-ci-robot @pierreprinetti @openshift-merge-robot