Skip to content

Conversation

@ingvagabund
Copy link
Member

@ingvagabund ingvagabund commented Oct 31, 2018

To build:

$ make libvirt-actuator

To create:

$ ./bin/libvirt-actuator --logtostderr create --cluster examples/cluster.yaml --machine examples/machine-with-userdata.yml  --userdata examples/ignition-userdata.yml

To delete:

$ ./bin/libvirt-actuator delete --cluster examples/cluster.yaml --machine examples/machine-with-userdata.yml  --userdata examples/ignition-userdata.yml --logtostderr

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 31, 2018
@ingvagabund
Copy link
Member Author

Still having issues with:

E1031 17:14:36.801738   24620 actuator.go:47] tb-asg-35/worker-example: error creating libvirt machine: error creating domain: error creating libvirt domain: virError(Code=1, Domain=10, Message='internal error: early end of file from monitor, possible problem: 2018-10-31T16:14:36.555216Z qemu-system-x86_64: -fw_cfg name=opt/com.coreos/config,file=/var/lib/libvirt/images/worker.ign: can't load /var/lib/libvirt/images/worker.ign')

Not sure what is wrong atm

@wking
Copy link
Member

wking commented Nov 15, 2018

can't load might be SELinux.

@ingvagabund
Copy link
Member Author

can't load might be SELinux.

Yes, it is!!!!!!!!

@ingvagabund ingvagabund changed the title WIP Allow to specify an ignition error through user secret Nov 21, 2018
@ingvagabund
Copy link
Member Author

So I am able to create an ignition volume.

@ingvagabund ingvagabund changed the title Allow to specify an ignition error through user secret Allow to specify an ignition configuration through user secret Nov 21, 2018
@bison
Copy link
Contributor

bison commented Nov 21, 2018

Should machine-with-userdata.yml be in the examples directory?

@ingvagabund
Copy link
Member Author

/retest

@bison
Copy link
Contributor

bison commented Nov 21, 2018

/lgtm

We have to create a CreateDomainOptions struct at some point... The signature for CreateDomain() is crazy.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2018
@ingvagabund
Copy link
Member Author

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2018
@openshift-merge-robot openshift-merge-robot merged commit 2b8c363 into openshift:master Nov 22, 2018
@ingvagabund ingvagabund deleted the igninition-volume-as-secret branch November 22, 2018 08:56
abhinavdahiya added a commit to abhinavdahiya/installer that referenced this pull request Nov 27, 2018
Thanks to @ingvagabund
openshift/cluster-api-provider-libvirt#86 allows specifying
a k8s secret as source for the userdata ignition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants