Skip to content

Use SPICE graphics only for x86_64 #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Dec 3, 2020
Merged

Use SPICE graphics only for x86_64 #215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions pkg/cloud/libvirt/client/domain.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,10 +106,8 @@ func newDevicesDef(virConn *libvirt.Connect) *libvirtxml.DomainDeviceList {
if err != nil {
glog.Errorf("Error retrieving host architecture: %s", err)
}
// Both "s390" and "s390x" are linux kernel architectures for Linux on IBM z Systems, and they are for 31-bit and 64-bit respectively.
// Graphics/Spice isn't supported on s390/s390x platform.
// Same case for PowerPC systems as well
if !strings.HasPrefix(arch, "s390") && !strings.HasPrefix(arch, "ppc64") {
// Currently SPICE is supported on x86_64 and aarch64. But it is only enabled in RHEL qemu for x86_64.
if arch == "x86_64" {
domainList.Graphics = []libvirtxml.DomainGraphic{
{
Spice: &libvirtxml.DomainGraphicSpice{
Expand Down