Add liveness/readiness probes #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elmiko
approved these changes
Jun 10, 2020
Contributor
elmiko
left a comment
elmiko
left a comment
There was a problem hiding this comment.
i'm not very familiar with healthz, but this looks reasonable to me.
/lgtm
Author
|
/retest |
Member
|
/retest |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
This was referenced Jun 18, 2020
Danil-Grigorev
pushed a commit
to Danil-Grigorev/machine-api-operator
that referenced
this pull request
Jun 22, 2020
OCPCLOUD-785 - health checks for all machine API controllers This introduce support for readinessProbe and livenessProbe [1] for the owned machine controllers deployment and its machineSet, MHC and machine controller containers. This will let the kubelet to better acknowledge about these containers lifecycle and therefore letting us to be more robust to signal the operator degradability on the clusterOperator status. This PR needs [2], [3] and [4] to work and pass CI so the probes included in the container spec here can get a 200 from the machine controllers. Also additionally [5], [6] and [7] must the same to not break or the probes included in the container spec here will fail will and result in the containers getting restarted. This also reverts accidental rebase and put back the syncPeriod which was dropped by [8]. [1] https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#container-probes [2] openshift/cluster-api-provider-aws#329 [3] openshift/cluster-api-provider-azure#139 [4] openshift/cluster-api-provider-gcp#96 [5] https://github.com/openshift/cluster-api-provider-openstack [6] https://github.com/openshift/cluster-api-provider-ovirt [7] https://github.com/metal3-io/cluster-api-provider-metal3 [8] https://github.com/openshift/machine-api-operator/pull/590/files#diff-7417e4bc31a1bacc1a431704bee56978L41
RadekManak
pushed a commit
to RadekManak/cluster-api-provider-gcp
that referenced
this pull request
Apr 12, 2023
…dules/github.com/onsi/gomega-1.27.5 🌱 Bump github.com/onsi/gomega from 1.27.4 to 1.27.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCPCLOUD-785 - health checks for all machine API controllers