Bug 1837124: Add the machine's name as a known NodeInternalDNS by openshift-cherrypick-robot · Pull Request #92 · openshift/cluster-api-provider-gcp

openshift-cherrypick-robot · 2020-05-18T21:27:37Z

This is an automated cherry-pick of #88

/assign abhinavdahiya

GCP platform provides search paths to resolve the virtual machine names by default. see https://cloud.google.com/compute/docs/internal-dns#resolv.conf this also allows nodes in clusters to have node-names matching the virtual machine name instead of the fqdn be because fqdn is too long for RHCOS to accept as hostname by default

openshift-ci-robot · 2020-05-18T21:27:51Z

@openshift-cherrypick-robot: Bugzilla bug 1809345 has been cloned as Bugzilla bug 1837125. Retitling PR to link against new bug.
/retitle [release-4.3] Bug 1837125: Add the machine's name as a known NodeInternalDNS

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-05-18T21:28:11Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1837125, which is invalid:

expected dependent Bugzilla bug 1809345 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead
expected dependent Bugzilla bug 1809345 to target a release in 4.4.0, 4.4.z, but it targets "4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

abhinavdahiya · 2020-05-19T18:16:43Z

/bugzilla refresh

openshift-ci-robot · 2020-05-19T18:16:46Z

@abhinavdahiya: This pull request references Bugzilla bug 1837125, which is invalid:

expected the bug to be open, but it isn't
expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is CLOSED (DUPLICATE) instead
expected dependent Bugzilla bug 1837122 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

abhinavdahiya · 2020-05-19T18:17:56Z

/retitle [release-4.3] Bug 1837124: Add the machine's name as a known NodeInternalDNS

openshift-ci-robot · 2020-05-19T18:18:12Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1837124, which is invalid:

expected dependent Bugzilla bug 1837122 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

michaelgugino

/lgtm

darkmuggle · 2020-05-19T21:37:31Z

/lgtm

openshift-bot · 2020-05-20T01:01:13Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-05-20T01:01:15Z

@openshift-bot: This pull request references Bugzilla bug 1837124, which is invalid:

expected dependent Bugzilla bug 1837122 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

enxebre · 2020-05-20T08:09:40Z

/retest
/approve

openshift-ci-robot · 2020-05-20T08:09:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [enxebre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-05-21T01:01:42Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-05-21T01:01:45Z

@openshift-bot: This pull request references Bugzilla bug 1837124, which is invalid:

expected dependent Bugzilla bug 1837122 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-05-22T01:01:35Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-05-22T01:01:38Z

@openshift-bot: This pull request references Bugzilla bug 1837124, which is invalid:

expected dependent Bugzilla bug 1837122 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-05-23T01:01:08Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-05-23T01:01:10Z

@openshift-bot: This pull request references Bugzilla bug 1837124, which is invalid:

expected dependent Bugzilla bug 1837122 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-05-24T01:00:44Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-05-24T01:00:47Z

@openshift-bot: This pull request references Bugzilla bug 1837124, which is invalid:

expected dependent Bugzilla bug 1837122 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-05-25T01:00:44Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-05-25T01:00:47Z

@openshift-bot: This pull request references Bugzilla bug 1837124, which is invalid:

expected dependent Bugzilla bug 1837122 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-05-26T01:00:36Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-05-26T01:00:39Z

@openshift-bot: This pull request references Bugzilla bug 1837124, which is invalid:

expected dependent Bugzilla bug 1837122 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-05-27T01:01:08Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-05-27T01:01:11Z

@openshift-bot: This pull request references Bugzilla bug 1837124, which is invalid:

expected dependent Bugzilla bug 1837122 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-05-28T01:00:52Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-05-28T01:00:55Z

@openshift-bot: This pull request references Bugzilla bug 1837124, which is invalid:

expected dependent Bugzilla bug 1837122 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sdodson · 2020-05-28T19:51:01Z

/bugzilla refresh

openshift-ci-robot · 2020-05-28T19:51:09Z

@sdodson: This pull request references Bugzilla bug 1837124, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.3.z) matches configured target release for branch (4.3.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1837122 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1837122 targets the "4.4.z" release, which is one of the valid target releases: 4.4.0, 4.4.z
bug has dependents

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

NautiluX · 2020-05-29T08:11:07Z

Anything missing for this to get merged? Glad to see we're bringing this fix to 4.3

ashcrow · 2020-05-29T13:48:40Z

/retitle Bug 1837124: Add the machine's name as a known NodeInternalDNS

openshift-ci-robot · 2020-05-29T14:06:11Z

@openshift-cherrypick-robot: Some pull requests linked via external trackers have merged: . The following pull requests linked via external trackers have not merged:

openshift/machine-config-operator#1738 is open
Bugzilla bug 1837124 has been moved to the MODIFIED state.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

🐛 Make release tag argument configurable

openshift-ci-robot assigned abhinavdahiya May 18, 2020

openshift-cherrypick-robot mentioned this pull request May 18, 2020

Bug 1809345: Add the machine's name as a known NodeInternalDNS #88

Merged

openshift-ci-robot requested review from bison and ingvagabund May 18, 2020 21:27

openshift-ci-robot changed the title ~~[release-4.3] Bug 1809345: Add the machine's name as a known NodeInternalDNS~~ [release-4.3] Bug 1837125: Add the machine's name as a known NodeInternalDNS May 18, 2020

openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 18, 2020

openshift-ci-robot changed the title ~~[release-4.3] Bug 1837125: Add the machine's name as a known NodeInternalDNS~~ [release-4.3] Bug 1837124: Add the machine's name as a known NodeInternalDNS May 19, 2020

michaelgugino approved these changes May 19, 2020

View reviewed changes

openshift-ci-robot assigned michaelgugino May 19, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2020

openshift-ci-robot assigned darkmuggle May 19, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 28, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 28, 2020

openshift-ci-robot changed the title ~~[release-4.3] Bug 1837124: Add the machine's name as a known NodeInternalDNS~~ Bug 1837124: Add the machine's name as a known NodeInternalDNS May 29, 2020

ashcrow added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 29, 2020

openshift-merge-robot merged commit fbb2ed7 into openshift:release-4.3 May 29, 2020

openshift-ci-robot mentioned this pull request May 29, 2020

Bug 1837124: templates: add etc-networkmanager-dispatcher.d-90-long-hostname.yaml openshift/machine-config-operator#1738

Merged

RadekManak pushed a commit to RadekManak/cluster-api-provider-gcp that referenced this pull request Apr 12, 2023

Merge pull request openshift#92 from alexander-demicev/releasetagarg

d807992

🐛 Make release tag argument configurable

Conversation

openshift-cherrypick-robot commented May 18, 2020

Uh oh!

openshift-ci-robot commented May 18, 2020

Uh oh!

openshift-ci-robot commented May 18, 2020

Uh oh!

abhinavdahiya commented May 19, 2020

Uh oh!

openshift-ci-robot commented May 19, 2020

Uh oh!

abhinavdahiya commented May 19, 2020

Uh oh!

openshift-ci-robot commented May 19, 2020

Uh oh!

michaelgugino left a comment

Choose a reason for hiding this comment

Uh oh!

darkmuggle commented May 19, 2020

Uh oh!

openshift-bot commented May 20, 2020

Uh oh!

openshift-ci-robot commented May 20, 2020

Uh oh!

enxebre commented May 20, 2020

Uh oh!

openshift-ci-robot commented May 20, 2020

Uh oh!

openshift-bot commented May 21, 2020

Uh oh!

openshift-ci-robot commented May 21, 2020

Uh oh!

openshift-bot commented May 22, 2020

Uh oh!

openshift-ci-robot commented May 22, 2020

Uh oh!

openshift-bot commented May 23, 2020

Uh oh!

openshift-ci-robot commented May 23, 2020

Uh oh!

openshift-bot commented May 24, 2020

Uh oh!

openshift-ci-robot commented May 24, 2020

Uh oh!

openshift-bot commented May 25, 2020

Uh oh!

openshift-ci-robot commented May 25, 2020

Uh oh!

openshift-bot commented May 26, 2020

Uh oh!

openshift-ci-robot commented May 26, 2020

Uh oh!

openshift-bot commented May 27, 2020

Uh oh!

openshift-ci-robot commented May 27, 2020

Uh oh!

openshift-bot commented May 28, 2020

Uh oh!

openshift-ci-robot commented May 28, 2020

Uh oh!

sdodson commented May 28, 2020

Uh oh!

openshift-ci-robot commented May 28, 2020

Uh oh!

NautiluX commented May 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ashcrow commented May 29, 2020

Uh oh!

openshift-ci-robot commented May 29, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

NautiluX commented May 29, 2020 •

edited

Loading