Skip to content

Bug 1837122: Add the machine's name as a known NodeInternalDNS #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
May 22, 2020
Merged

Bug 1837122: Add the machine's name as a known NodeInternalDNS #91

openshift-merge-robot merged 1 commit into from
May 22, 2020

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented May 18, 2020

This is an automated cherry-pick of #88

/assign abhinavdahiya

@abhinavdahiya
Add the machine's name as a known NodeInternalDNS
3899b5f 
GCP platform provides search paths to resolve the virtual machine names by default. see https://cloud.google.com/compute/docs/internal-dns#resolv.conf

this also allows nodes in clusters to have node-names matching the virtual machine name instead of the fqdn be because fqdn is too long for RHCOS to accept as hostname
by default
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 18, 2020
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 18, 2020

@openshift-cherrypick-robot: Detected clone of Bugzilla bug 1809345 with correct target release. Retitling PR to link to clone:
/retitle [release-4.4] Bug 1837122: Add the machine's name as a known NodeInternalDNS

Details

In response to this:

[release-4.4] Bug 1809345: Add the machine's name as a known NodeInternalDNS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.4] Bug 1809345: Add the machine's name as a known NodeInternalDNS [release-4.4] Bug 1837122: Add the machine's name as a known NodeInternalDNS May 18, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 18, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 18, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1837122, which is invalid:

  • expected dependent Bugzilla bug 1809345 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.4] Bug 1837122: Add the machine's name as a known NodeInternalDNS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented May 19, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 19, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 19, 2020

@abhinavdahiya: This pull request references Bugzilla bug 1837122, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.4.z) matches configured target release for branch (4.4.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1809345 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1809345 targets the "4.5.0" release, which is one of the valid target releases: 4.5.0, 4.5.z
  • bug has dependents
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 19, 2020
@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented May 19, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 19, 2020

@abhinavdahiya: This pull request references Bugzilla bug 1837122, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.4.z) matches configured target release for branch (4.4.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1809345 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1809345 targets the "4.5.0" release, which is one of the valid target releases: 4.5.0, 4.5.z
  • bug has dependents
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

michaelgugino
michaelgugino approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@michaelgugino michaelgugino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2020
@darkmuggle
Copy link

darkmuggle commented May 19, 2020

/lgtm

@enxebre
Copy link
Member

enxebre commented May 20, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 20, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2020
@sdodson
Copy link
Member

sdodson commented May 21, 2020

/retitle Bug 1837122: Add the machine's name as a known NodeInternalDNS

@openshift-ci-robot openshift-ci-robot changed the title [release-4.4] Bug 1837122: Add the machine's name as a known NodeInternalDNS Bug 1837122: Add the machine's name as a known NodeInternalDNS May 21, 2020
@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 22, 2020
@openshift-merge-robot openshift-merge-robot merged commit a7c9923 into openshift:release-4.4 May 22, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 22, 2020

@openshift-cherrypick-robot: Some pull requests linked via external trackers have merged: openshift/cluster-api-provider-gcp#91. The following pull requests linked via external trackers have not merged:

Details

In response to this:

Bug 1837122: Add the machine's name as a known NodeInternalDNS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request May 22, 2020
Merged
RadekManak pushed a commit to RadekManak/cluster-api-provider-gcp that referenced this pull request Apr 12, 2023
@k8s-ci-robot
Merge pull request openshift#91 from alexander-demicev/fixworkflow
06b4b9e 
🌱 Fix release workflow version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@enxebre enxebre Awaiting requested review from enxebre

1 more reviewer

@michaelgugino michaelgugino michaelgugino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@darkmuggle darkmuggle

@abhinavdahiya abhinavdahiya

@michaelgugino michaelgugino

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@openshift-cherrypick-robot @openshift-ci-robot @abhinavdahiya @darkmuggle @enxebre @sdodson @michaelgugino @openshift-merge-robot