[OCPCLOUD-492] Implement leader election for gcp provider #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

openshift-merge-robot merged 1 commit into openshift:master from Danil-Grigorev:leader-election-gcp

Jul 4, 2020

Danil-Grigorev commented Apr 23, 2020

Couple of new cli arguments for configuring leader election:

  -leader-elect
    	Start a leader election client and gain leadership before executing the main loop. Enable this when running replicated components for high availability. (default true)
  -leader-elect-lease-duration int
    	The duration that non-leader candidates will wait after observing a leadership renewal until attempting to acquire leadership of a led but unrenewed leader slot. This is effectively the maximum duration that a leader can be stopped before it is replaced by another candidate. This is only applicable if leader election is enabled. (default 15s)
  -leader-elect-resource-namespace string
    	The namespace of resource object that is used for locking during leader election. If unspecified, the controller watches for machine-api objects across all namespaces.

openshift-ci-robot requested review from JoelSpeed and alexander-demicev

April 23, 2020 09:25

JoelSpeed reviewed

View reviewed changes

cmd/manager/main.go Outdated Show resolved Hide resolved

Danil-Grigorev force-pushed the leader-election-gcp branch 3 times, most recently from 916a5f1 to c20c673 Compare

April 23, 2020 10:07

JoelSpeed reviewed

View reviewed changes

Contributor

JoelSpeed left a comment

/approve

Contributor

openshift-ci-robot commented Apr 23, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot added the approved label

enxebre added the release/4.6 label

Danil-Grigorev force-pushed the leader-election-gcp branch from c20c673 to 7699a71 Compare

June 19, 2020 13:06


          Implement leader election for gcp provider

8b1645c

Danil-Grigorev force-pushed the leader-election-gcp branch from 7699a71 to 8b1645c Compare

June 19, 2020 19:39

Contributor

JoelSpeed commented Jun 22, 2020

/retitle [OCPCLOUD-492] Implement leader election for gcp provider

openshift-ci-robot changed the title ~~[OCPCLOUD-492] Implemented leader election for gcp provider~~ [OCPCLOUD-492] Implement leader election for gcp provider

Member

enxebre commented Jul 2, 2020

/lgtm

openshift-ci-robot assigned enxebre

openshift-ci-robot added the lgtm label

Contributor

openshift-bot commented Jul 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Danil-Grigorev mentioned this pull request

OCPCLOUD-492: Leader election for machineSets, nodelink, vsphere and healthchecks openshift/machine-api-operator#571

Merged

Contributor

openshift-bot commented Jul 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

9 similar comments

Contributor

openshift-bot commented Jul 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

19 similar comments

Contributor

openshift-bot commented Jul 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Jul 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-merge-robot merged commit 48cf70b into openshift:master

Danil-Grigorev pushed a commit to Danil-Grigorev/machine-api-operator that referenced this pull request


          Set leader-election for all controllers enabled

f0929b9

Using leader election by default will add stronger guarantees than we have today that only one controller is running at a time to protect against edge cases where the deployment replica could be increased or upgrades with permissive maxSurge.

Relevant provider PRs:

- openshift/cluster-api-provider-gcp#85
- openshift/cluster-api-provider-aws#315
- openshift/cluster-api-provider-azure#122
- openshift/cluster-api-provider-openstack#108
- openshift/cluster-api-provider-baremetal#81
- openshift/cluster-api-provider-ovirt#55
- openshift#571

elmiko pushed a commit to elmiko/machine-api-operator that referenced this pull request


          Set leader-election for all controllers enabled

303f931

Using leader election by default will add stronger guarantees than we have today that only one controller is running at a time to protect against edge cases where the deployment replica could be increased or upgrades with permissive maxSurge.

Relevant provider PRs:

- openshift/cluster-api-provider-gcp#85
- openshift/cluster-api-provider-aws#315
- openshift/cluster-api-provider-azure#122
- openshift/cluster-api-provider-openstack#108
- openshift/cluster-api-provider-baremetal#81
- openshift/cluster-api-provider-ovirt#55
- openshift#571

RadekManak pushed a commit to RadekManak/cluster-api-provider-gcp that referenced this pull request


          Merge pull request openshift#85 from kubernetes-sigs/dependabot/githu…

ec97ebb

…b_actions/actions/setup-go-4

🌱 Bump actions/setup-go from 3 to 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release/4.6