support sourceImage outside the existing project#101
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Jul 10, 2020
Merged
support sourceImage outside the existing project#101openshift-merge-robot merged 1 commit intoopenshift:masterfrom
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
Based on the api reference for compute.instance.insert [0] ``` disks[].initializeParams.sourceImage: The source image to create this disk. When creating a new instance, one of initializeParams.sourceImage or initializeParams.sourceSnapshot or disks.source is required except for local SSD. To create a disk with one of the public operating system images, specify the image by its family name. For example, specify family/debian-9 to use the latest Debian 9 image: projects/debian-cloud/global/images/family/debian-9 Alternatively, use a specific version of a public operating system image: projects/debian-cloud/global/images/debian-9-stretch-vYYYYMMDD To create a disk with a custom image that you created, specify the image name in the following format: global/images/my-custom-image You can also specify a custom image by its image family, which returns the latest version of the image in that family. Replace the image name with family/family-name: global/images/family/my-image-family ``` Currently the provider always assumes that the image will be in the same project as the machine and it massages the input to match that. To allow users to provide source image based on examples mentioned above, we pass it as-is unless we know that input is just image-name. [0]: https://cloud.google.com/compute/docs/reference/rest/v1/instances/insert
Contributor
Author
|
we would need to use pre existing images for RHCOS openshift/installer#3808 |
elmiko
approved these changes
Jul 9, 2020
Contributor
elmiko
left a comment
elmiko
left a comment
There was a problem hiding this comment.
this looks reasonable to me, i'd like to have someone more familiar with the gcp provider add the approved label though.
/lgtm
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michaelgugino The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Contributor
Author
|
/retest |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the api reference for compute.instance.insert
Currently the provider always assumes that the image will be in the same project as the machine and it massages the input to match that.
To allow users to provide source image based on examples mentioned above, we pass it as-is unless we know that input is just image-name.