Skip to content

Comments

BUG 1877743: Bump K8s dependencies to v1.19.0#109

Closed
JoelSpeed wants to merge 1 commit intoopenshift:masterfrom
JoelSpeed:mao-update-cac610d6
Closed

BUG 1877743: Bump K8s dependencies to v1.19.0#109
JoelSpeed wants to merge 1 commit intoopenshift:masterfrom
JoelSpeed:mao-update-cac610d6

Conversation

@JoelSpeed
Copy link

@JoelSpeed JoelSpeed commented Sep 11, 2020

Our dependencies are out of date and should be on K8s 1.19.0 before the 4.6 release to match the rest of the core components. This PR updates all of the K8s and openshift depdendencies to include the lastest 1.19.0 release.

@openshift-ci-robot
Copy link

@JoelSpeed: This pull request references Bugzilla bug 1877743, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

BUG 1877743: Bump K8s dependencies to v1.19.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 11, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JoelSpeed
To complete the pull request process, please assign russellb
You can assign the PR to them by writing /assign @russellb in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

@JoelSpeed: This pull request references Bugzilla bug 1877743, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

BUG 1877743: Bump K8s dependencies to v1.19.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zaneb
Copy link
Member

zaneb commented Sep 11, 2020

#110 fixes the managerWrapper error.

@zaneb
Copy link
Member

zaneb commented Sep 11, 2020

Forcing the latest version of zapr with go get -d github.com/go-logr/zapr@latest seems to resolve the other build failure.

@zaneb
Copy link
Member

zaneb commented Sep 12, 2020

There were some unit test fixes required as well. I can't push to this branch, so I pushed fixes to #96. We can retitle that one and merge it, or feel free to just push those patches here.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 13, 2020
@openshift-ci-robot
Copy link

@JoelSpeed: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JoelSpeed
Copy link
Author

@zaneb Feel free to close this one and take over the capbm part of the attached bug in #96 👍

@openshift-ci-robot
Copy link

@JoelSpeed: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-metal-ipi 1b7b352 link /test e2e-metal-ipi
ci/prow/govet 1b7b352 link /test govet
ci/prow/images 1b7b352 link /test images
ci/prow/unit 1b7b352 link /test unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zaneb
Copy link
Member

zaneb commented Sep 14, 2020

/close
in favour of #96

@openshift-ci-robot
Copy link

@zaneb: Closed this PR.

Details

In response to this:

/close
in favour of #96

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@JoelSpeed: This pull request references Bugzilla bug 1877743. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

BUG 1877743: Bump K8s dependencies to v1.19.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants