Skip to content

Comments

Migrate to opeshift/api#236

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
alexander-demicev:apimigrate
Nov 4, 2021
Merged

Migrate to opeshift/api#236
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
alexander-demicev:apimigrate

Conversation

@alexander-demicev
Copy link

This PR migrate all API definitions to openshift/api and:

  • revendored dependcies
  • removed api definitions from repo
  • keep conversion functions as aliases
  • replace imports

@alexander-demicev
Copy link
Author

/retest

Copy link

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link

openshift-ci bot commented Nov 4, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2021
@lobziik
Copy link

lobziik commented Nov 4, 2021

/lgtm
/hold
Wanna see e2e-azure last results

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2021
@lobziik
Copy link

lobziik commented Nov 4, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2021
@openshift-merge-robot openshift-merge-robot merged commit 23f979c into openshift:master Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants