Skip to content

[release-4.6] Bug 1885996: Fix missing logs due to mixed klog versions#171

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.6from
openshift-cherrypick-robot:cherry-pick-170-to-release-4.6
Nov 5, 2020
Merged

[release-4.6] Bug 1885996: Fix missing logs due to mixed klog versions#171
openshift-merge-robot merged 1 commit intoopenshift:release-4.6from
openshift-cherrypick-robot:cherry-pick-170-to-release-4.6

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Oct 7, 2020

This is an automated cherry-pick of #170

/assign JoelSpeed

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 7, 2020
Merged
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 7, 2020

@openshift-cherrypick-robot: Bugzilla bug 1885151 has been cloned as Bugzilla bug 1885996. Retitling PR to link against new bug.
/retitle [release-4.6] Bug 1885996: Fix missing logs due to mixed klog versions

Details

In response to this:

[release-4.6] Bug 1885151: Fix missing logs due to mixed klog versions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.6] Bug 1885151: Fix missing logs due to mixed klog versions [release-4.6] Bug 1885996: Fix missing logs due to mixed klog versions Oct 7, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Oct 7, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 7, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1885996, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1885151 is in the state MODIFIED, which is one of the valid states (MODIFIED, VERIFIED)
  • dependent Bugzilla bug 1885151 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
  • bug has dependents
Details

In response to this:

[release-4.6] Bug 1885996: Fix missing logs due to mixed klog versions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alexander-demicev
alexander-demicev approved these changes Oct 7, 2020
View reviewed changes
Copy link

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 7, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-demichev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 7, 2020

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-azure-operator d66f9cd link /test e2e-azure-operator

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sunzhaohua2
Copy link

sunzhaohua2 commented Nov 4, 2020

/bugzilla cc-qa
(I'm following the issue DPTP-660 to do the pre-merge verifying)

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 4, 2020

@sunzhaohua2: This pull request references Bugzilla bug 1885996, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1885151 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1885151 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
  • bug has dependents

Requesting review from QA contact:
/cc @sunzhaohua2

Details

In response to this:

/bugzilla cc-qa
(I'm following the issue DPTP-660 to do the pre-merge verifying)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sunzhaohua2
Copy link

sunzhaohua2 commented Nov 4, 2020 •
edited by openshift-ci-robot
Loading

Already pre-merge verified in 1885996#c2, so per DPTP-660 adding:
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2020
@openshift-bot
Copy link

openshift-bot commented Nov 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link

openshift-bot commented Nov 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Nov 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Nov 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Nov 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Nov 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Nov 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Nov 4, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 5, 2020
@openshift-bot
Copy link

openshift-bot commented Nov 5, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Nov 5, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

openshift-bot commented Nov 5, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Nov 5, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 238fde6 into openshift:release-4.6 Nov 5, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 5, 2020

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1885996 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.6] Bug 1885996: Fix missing logs due to mixed klog versions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Danil-Grigorev Danil-Grigorev Awaiting requested review from Danil-Grigorev

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@sunzhaohua2 sunzhaohua2 Awaiting requested review from sunzhaohua2

1 more reviewer

@alexander-demicev alexander-demicev alexander-demicev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JoelSpeed JoelSpeed

@sunzhaohua2 sunzhaohua2

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@openshift-cherrypick-robot @openshift-ci-robot @sunzhaohua2 @openshift-bot @alexander-demicev @sdodson @JoelSpeed @openshift-merge-robot