Skip to content

Bug 1872080: Add Dockerfile.rhel to match build configuration in ocp-build-data#161

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
elmiko:bz-1872080
Sep 2, 2020
Merged

Bug 1872080: Add Dockerfile.rhel to match build configuration in ocp-build-data#161
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
elmiko:bz-1872080

Conversation

@elmiko
Copy link

@elmiko elmiko commented Aug 25, 2020

This PR is a copy of the autogenerated PR by the
ocp-build-data-enforcer.
It updates the baseimages in the Dockerfile used for promotion in order
to ensure it matches the configuration in the ocp-build-data
repository

used for producing release artifacts.

If you believe the content of this PR is incorrect, please contact the
dptp team in #forum-testplatform

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 25, 2020
@openshift-ci-robot
Copy link

@elmiko: This pull request references Bugzilla bug 1872080, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1872080: Updating Dockerfile baseimages to mach ocp-build-data config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elmiko
Copy link
Author

elmiko commented Aug 25, 2020

this is a reposting of #160 to correct the git commit message.

…iguration in ocp-build-data

This change adds a new Dockerfile.rhel file to control building release
images. It updates the baseimages in the Dockerfile used for promotion
in order to ensure it matches the configuration in the
[ocp-build-data
repository](https://github.com/openshift/ocp-build-data/tree/openshift-4.6-rhel-8/images)
used for producing release artifacts.

After this change merges, the release files in
https://github.com/openshift/release/blob/master/ci-operator/config/openshift/cluster-api-provider-azure/openshift-cluster-api-provider-azure-master.yaml
should be updated with the new dockerfile path.
@elmiko
Copy link
Author

elmiko commented Aug 25, 2020

/retitle Bug 1872080: Add Dockerfile.rhel to match build configuration in ocp-build-data

@openshift-ci-robot openshift-ci-robot changed the title Bug 1872080: Updating Dockerfile baseimages to mach ocp-build-data config Bug 1872080: Add Dockerfile.rhel to match build configuration in ocp-build-data Aug 25, 2020
@elmiko
Copy link
Author

elmiko commented Aug 25, 2020

i updated this to add a new file after discussion with @michaelgugino and on our mailing-list.

Copy link

@michaelgugino michaelgugino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2020
@jupierce
Copy link

/retest

2 similar comments
@yselkowitz
Copy link

/retest

@crawford
Copy link

crawford commented Sep 1, 2020

/retest

@enxebre
Copy link
Member

enxebre commented Sep 1, 2020

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

elmiko added a commit to elmiko/ocp-build-data that referenced this pull request Sep 2, 2020
@elmiko
Copy link
Author

elmiko commented Sep 2, 2020

adding a reference to the dependent PR, openshift-eng/ocp-build-data#636

@elmiko
Copy link
Author

elmiko commented Sep 2, 2020

/test e2e-azure-operator

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@crawford
Copy link

crawford commented Sep 2, 2020

The e2e-azure-operator job has been failing consistently for a while, starting before this PR. Looking through individual results, I don't see a common pattern other than OpenShift on Azure generally being too slow for our CI's liking. As such, I'm going to override this test.

/override ci/prow/e2e-azure-operator

@openshift-ci-robot
Copy link

@crawford: Overrode contexts on behalf of crawford: ci/prow/e2e-azure-operator

Details

In response to this:

The e2e-azure-operator job has been failing consistently for a while, starting before this PR. Looking through individual results, I don't see a common pattern other than OpenShift on Azure generally being too slow for our CI's liking. As such, I'm going to override this test.

/override ci/prow/e2e-azure-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elmiko
Copy link
Author

elmiko commented Sep 2, 2020

thanks Alex, it looked like flakes from azure

@openshift-merge-robot openshift-merge-robot merged commit 72169c5 into openshift:master Sep 2, 2020
@openshift-ci-robot
Copy link

@elmiko: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1872080 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 1872080: Add Dockerfile.rhel to match build configuration in ocp-build-data

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants