Skip to content

BUG 1858400: [Performance] Lease refresh period for machine-api-controllers is too high, causes heavy writes to etcd at idle #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Aug 20, 2020
Merged

BUG 1858400: [Performance] Lease refresh period for machine-api-controllers is too high, causes heavy writes to etcd at idle #157

openshift-merge-robot merged 1 commit into from
Aug 20, 2020

Conversation

@Danil-Grigorev
Copy link

@Danil-Grigorev Danil-Grigorev commented Aug 12, 2020 •
edited
Loading

Reduce default lease retry rate on 30s which will prevent from heavy writes into etcd at idle, and constrain renew deadline on 90s.

Inspired by openshift/cloud-credential-operator#231
Depends on openshift/machine-api-operator#675

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Aug 12, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 12, 2020

@Danil-Grigorev: This pull request references Bugzilla bug 1858400, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

BUG 1858400: [Performance] Lease refresh period for machine-api-controllers is too high, causes heavy writes to etcd at idle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 12, 2020
@elmiko elmiko mentioned this pull request Aug 12, 2020
Merged
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 13, 2020

@Danil-Grigorev: This pull request references Bugzilla bug 1858400, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

BUG 1858400: [Performance] Lease refresh period for machine-api-controllers is too high, causes heavy writes to etcd at idle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Danil-Grigorev
Copy link
Author

Danil-Grigorev commented Aug 13, 2020

/retest

2 similar comments
@Danil-Grigorev
Copy link
Author

Danil-Grigorev commented Aug 18, 2020

/retest

@Danil-Grigorev
Copy link
Author

Danil-Grigorev commented Aug 18, 2020

/retest

UPSTREAM: <carry>: openshift: Slow the default lease retry and renew …
840afa6 
…rate for machine controller

Prevent machine controllers from writing in etcd at idle too often
by setting 120s lease, 20s retry and 110s deadline on all renewals.
Higher values for retry cause tests to flake.
BZ 1858403
@Danil-Grigorev
Copy link
Author

Danil-Grigorev commented Aug 19, 2020

/retest

1 similar comment
@Danil-Grigorev
Copy link
Author

Danil-Grigorev commented Aug 19, 2020

/retest

michaelgugino
michaelgugino approved these changes Aug 19, 2020
View reviewed changes
Copy link

@michaelgugino michaelgugino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2020
elmiko
elmiko approved these changes Aug 20, 2020
View reviewed changes
Copy link

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 20, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2020
@openshift-bot
Copy link

openshift-bot commented Aug 20, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Aug 20, 2020
Merged
@openshift-bot
Copy link

openshift-bot commented Aug 20, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

openshift-bot commented Aug 20, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Aug 20, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 201dd37 into openshift:master Aug 20, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 20, 2020

@Danil-Grigorev: Some pull requests linked via external trackers have merged: openshift/machine-api-operator#675, openshift/machine-api-operator#649, openshift/cluster-api-provider-ovirt#56, openshift/cluster-api-provider-openstack#109, openshift/cluster-api-provider-gcp#115, openshift/cluster-api-provider-gcp#104, openshift/cluster-api-provider-baremetal#88, openshift/cluster-api-provider-azure#157, openshift/cluster-api-provider-azure#152. The following pull requests linked via external trackers have not merged:

Bugzilla bug 1858400 has been moved to the MODIFIED state.

Details

In response to this:

BUG 1858400: [Performance] Lease refresh period for machine-api-controllers is too high, causes heavy writes to etcd at idle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Aug 24, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexander-demicev alexander-demicev Awaiting requested review from alexander-demicev

2 more reviewers

@elmiko elmiko elmiko approved these changes

@michaelgugino michaelgugino michaelgugino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@michaelgugino michaelgugino

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Danil-Grigorev @openshift-ci-robot @openshift-bot @elmiko @michaelgugino @openshift-merge-robot