Skip to content

Bug 1857175: Revendor mao to bring https://github.com/openshift/machine-api-operator/pull/644 #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jul 22, 2020
Merged

Bug 1857175: Revendor mao to bring https://github.com/openshift/machine-api-operator/pull/644 #153

openshift-merge-robot merged 1 commit into from
Jul 22, 2020

Conversation

@enxebre
Copy link
Member

@enxebre enxebre commented Jul 22, 2020

This is to bring openshift/machine-api-operator#644 and so restoring the previous backend behaviour in the machine controller openshift/machine-api-operator@261c337

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jul 22, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 22, 2020

@enxebre: This pull request references Bugzilla bug 1857175, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1857175: Revendor mao to bring openshift/machine-api-operator#644

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 22, 2020
@enxebre enxebre mentioned this pull request Jul 22, 2020
Merged
@JoelSpeed
Copy link

JoelSpeed commented Jul 22, 2020

/approve

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 22, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2020
alexander-demicev
alexander-demicev approved these changes Jul 22, 2020
View reviewed changes
Copy link

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2020
@openshift-bot
Copy link

openshift-bot commented Jul 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

openshift-bot commented Jul 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jul 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Jul 22, 2020
Merged
@openshift-merge-robot openshift-merge-robot merged commit f1d6f90 into openshift:master Jul 22, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 22, 2020

@enxebre: All pull requests linked via external trackers have merged: openshift/machine-api-operator#653, openshift/machine-api-operator#644, openshift/cluster-api-provider-gcp#106, openshift/cluster-api-provider-azure#153, openshift/cluster-api-provider-aws#341. Bugzilla bug 1857175 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1857175: Revendor mao to bring openshift/machine-api-operator#644

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elmiko elmiko Awaiting requested review from elmiko

@michaelgugino michaelgugino Awaiting requested review from michaelgugino

1 more reviewer

@alexander-demicev alexander-demicev alexander-demicev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alexander-demicev alexander-demicev

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@enxebre @openshift-ci-robot @JoelSpeed @openshift-bot @alexander-demicev @openshift-merge-robot