Skip to content

Do not hardcode GOARCH/GOOS#149

Closed
yselkowitz wants to merge 1 commit intoopenshift:masterfrom
multi-arch:master
Closed

Do not hardcode GOARCH/GOOS#149
yselkowitz wants to merge 1 commit intoopenshift:masterfrom
multi-arch:master

Conversation

@yselkowitz
Copy link

What this PR does / why we need it:
This is needed for multi-arch enablement of this container image.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

NONE

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign joelspeed
You can assign the PR to them by writing /assign @joelspeed in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yselkowitz
Copy link
Author

/retest

Copy link

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I am curious though, how will the arch be determined? Will there be multiple versions of the dockerfile or will it be based on the system it's built on and pulling the correct arch of the release golang builder?

@yselkowitz
Copy link
Author

Manifest-list images automatically pull from the native architecture, and golang automatically compiles for the native architecture.

@JoelSpeed
Copy link

So this would mean we would have to build an arm image on an arm box? Windows on a windows box etc?
Non blocking, just for my own curiousity, but is it possible to publish all of the arch images from the same machine? Cross building?

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2020
@yselkowitz
Copy link
Author

So this would mean we would have to build an arm image on an arm box? Windows on a windows box etc?

Yes.

Non blocking, just for my own curiousity, but is it possible to publish all of the arch images from the same machine? Cross building?

Not feasibly.

@yselkowitz
Copy link
Author

/retest

2 similar comments
@yselkowitz
Copy link
Author

/retest

@yselkowitz
Copy link
Author

/retest

@openshift-ci-robot
Copy link

@yselkowitz: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-azure-operator 23017bd link /test e2e-azure-operator

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yselkowitz
Copy link
Author

Obsoleted by ab01fde

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants