Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest |
JoelSpeed
left a comment
There was a problem hiding this comment.
LGTM, I am curious though, how will the arch be determined? Will there be multiple versions of the dockerfile or will it be based on the system it's built on and pulling the correct arch of the release golang builder?
|
Manifest-list images automatically pull from the native architecture, and golang automatically compiles for the native architecture. |
|
So this would mean we would have to build an arm image on an arm box? Windows on a windows box etc? /lgtm |
Yes.
Not feasibly. |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
@yselkowitz: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Obsoleted by ab01fde |
What this PR does / why we need it:
This is needed for multi-arch enablement of this container image.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: