Add support for spot instances#143
Add support for spot instances#143openshift-merge-robot merged 2 commits intoopenshift:masterfrom alexander-demicev:spot1
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
| return base64.StdEncoding.EncodeToString(data), nil | ||
| } | ||
|
|
||
| func getSpotVMOptions(spotVMOptions *v1beta1.SpotVMOptions) (compute.VirtualMachinePriorityTypes, compute.VirtualMachineEvictionPolicyTypes, *compute.BillingProfile, error) { |
There was a problem hiding this comment.
Can we add a unit test for this function?
| MaxPrice: &maxPrice, | ||
| } | ||
| } | ||
| return compute.Spot, compute.Deallocate, billingProfile, nil |
There was a problem hiding this comment.
Can we add a comment elaborating why you chose Deallocate?
|
Can we add a ref in the commit desc to #138 and explain support for spot instances was split into that PR and this one? |
|
@enxebre all done |
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@alexander-demichev: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 participants
This PR is follow-up for #138 and adds support for spot instances.
API exposure of spot instances to provider spec and label setting was added in the previous PR.
https://github.com/openshift/enhancements/blob/master/enhancements/machine-api/spot-instances.md
kubernetes-sigs#559