Drop duplicate instance tags, if exists

[trawler]

related to: openshift/installer#468 (comment)

[frobware]

You don't need to == true.

[frobware]

This, I think, can be reduced to:

    ...
    keys := make(map[string]bool)
    result := []*ec2.Tag{}
    for _, entry := range tags {
        if _, value := keys[*entry.Key]; !value {
            keys[*entry.Key] = true
            result = append(result, entry)
        }
    }    
    return result
}

but untested - I just typed it out!

Please could you also create a unit test for this function as it it generic.

[frobware]

This, I think, can be reduced to:

    ...
    keys := make(map[string]bool)
    result := []*ec2.Tag{}
    for _, entry := range tags {
        if _, value := keys[*entry.Key]; !value {
            keys[*entry.Key] = true
            result = append(result, entry)
        }
    }    
    return result
}

but untested - I just typed it out!

Please could you also create a unit test for this function as it it generic.

[enxebre]

looking great! can we please include a unit test for this?

[paulfantom]

/test e2e-aws

[frobware]

The length doesn't guarantee correctness. Better to have expected and actual and use reflect.DeepEquals to verify the result.

[frobware]

Add the empty case (i.e., empty slices).

[frobware]

I think it would be more succinct to reduce all of this output to just:

t.Errorf("test #%d: expected %+v, got %+v", c.expected, actual)

as the inputs are quite small.

[ingvagabund]

Can't we just put all the tags under a map and then check if the key already exists?

tagMap := make(map[string]struct{})
for _, tag := range machineProviderConfig.Tags {
 		tagMap[tag.Name] = struct{}{}
}
if _, exists := tagMap["clusterid"]; !exists {
 		tagList = append(tagList, {Key: aws.String("clusterid"), Value: aws.String(clusterID)}}
}
...

[enxebre]

personally I like current implementation. It prevents also from injecting duplications @frobware wdyt?

[frobware]

I kind of prefer the de-dupe phase. It's easier to rationalise. I have a bunch of tags, then a last action is to de-dupe them.

[enxebre]

/lgtm

[frobware]

/lgtm

[frobware]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frobware

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [frobware]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment