-
Notifications
You must be signed in to change notification settings - Fork 49
[release-4.19] OCPBUGS-55998: Update manifests to remove reliance on v1beta1 admission registration #552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.19] OCPBUGS-55998: Update manifests to remove reliance on v1beta1 admission registration #552
Conversation
|
@JoelSpeed: This pull request references Jira Issue OCPBUGS-55998, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@JoelSpeed: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm The duplicate content is weird, but presumably not an issue with this PR. |
|
@JoelSpeed What do you want to do with the snyk warnings? They don't look relevant, but we should probably make them go away. |
damdo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damdo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I've went through the security warnings and dealt with them /test security |
|
/label backport-risk-assessed |
|
/jira refresh |
|
@damdo: This pull request references Jira Issue OCPBUGS-55998, which is valid. 7 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label cherry-pick-approved |
8024520
into
openshift:release-4.19
|
@JoelSpeed: Jira Issue OCPBUGS-55998: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-55998 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-aws-cluster-api-controllers |
|
Fix included in accepted release 4.19.0-0.nightly-2025-05-15-095920 |
|
Fix included in accepted release 4.19.0-0.nightly-2025-05-15-183918 |
Manual backport to update the branch for manifests-gen to the 4.19 release
Supercedes #550