Fix termination unsupported scheme test #377
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error message coming out of the URL package has changed between 1.14 and 1.15. The unit test was not updated to account for this change when the scripts were upgraded. This should resolve existing unit testing issues in 1.15.
openshift-ci-robot
added
the
approved
|
it seems like this is also fixed with #332 which has labels on it, i think we should close this issue. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci-robot
removed
the
approved
Author
|
#332 has now merged, this is no longer relevant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error message coming out of the URL package has changed between 1.14 and 1.15. The unit test was not updated to account for this change when the scripts were upgraded. This should resolve existing unit testing issues in 1.15.
This unit test was illegitimately blocking #374 from merging, this should resolve that issue.