Drop openssh from the image #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

openshift-merge-robot merged 1 commit into openshift:master from enxebre:ssh-dockerfile

Apr 17, 2020

Member

enxebre commented Apr 17, 2020

First introduced here https://github.com/openshift/cluster-api-provider-aws/pull/12/files. I don't see a reason to keep it.


          Drop openssh from the image

6f17024

openshift-ci-robot requested review from JoelSpeed and michaelgugino

April 17, 2020 14:04

alexander-demicev approved these changes

View reviewed changes

alexander-demicev left a comment

/approve

openshift-ci-robot commented Apr 17, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-demichev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [alexander-demichev]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot added the approved label

JoelSpeed reviewed

View reviewed changes

JoelSpeed left a comment

Have we verified that this works without openssh? I can't see why it wouldn't

Member Author

enxebre commented Apr 17, 2020 •

edited

Loading

Have we verified that this works without openssh? I can't see why it wouldn't

I think this is an old carry cover. Our CI will be verified that.

JoelSpeed commented Apr 17, 2020

Ack

/lgtm

openshift-ci-robot assigned JoelSpeed

openshift-ci-robot added the lgtm label

Member Author

enxebre commented Apr 17, 2020

/retest

openshift-bot commented Apr 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments

openshift-bot commented Apr 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Apr 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Apr 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented Apr 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-merge-robot merged commit 90bf20b into openshift:master

Fedosin mentioned this pull request

Drop openssh from the image openshift/cluster-api-provider-openstack#135

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels