Skip to content

Comments

Add a new Tag to identify which partner created the resource#15

Merged
openshift-merge-robot merged 3 commits intoopenshift:mainfrom
menglingwei:feature/add-more-tags-when-runinstances
Nov 30, 2021
Merged

Add a new Tag to identify which partner created the resource#15
openshift-merge-robot merged 3 commits intoopenshift:mainfrom
menglingwei:feature/add-more-tags-when-runinstances

Conversation

@menglingwei
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 15, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 15, 2021

Hi @menglingwei. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from Fedosin and lobziik November 15, 2021 09:41
@menglingwei
Copy link
Contributor Author

We want to identify that these resources are created through the Openshift platform.

@kwoodson
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 17, 2021
@kwoodson
Copy link
Contributor

@menglingwei Please rebase this PR. I have updated the ResourceTagReference to an AlibabaResourceReference. Thanks!

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2021
@kwoodson
Copy link
Contributor

@menglingwei Please rebase using the latest changes.

@menglingwei
Copy link
Contributor Author

@menglingwei Please rebase using the latest changes.
go it.

@openshift-ci openshift-ci bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 19, 2021
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 19, 2021
@menglingwei
Copy link
Contributor Author

@kwoodson Any suggestion about this PR?

@kwoodson
Copy link
Contributor

@menglingwei No suggestions but this PR should go together with github.com/openshift/installer/pull/5385. As soon as the installer merges we can merge this one.

@fabianofranz
Copy link
Member

openshift/installer#5385 is merged

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2021
@fabianofranz
Copy link
Member

/assign @lobziik @Fedosin

Mind taking a look and approving? Tks!

@kwoodson
Copy link
Contributor

Tested this change along with #20. Everything looks good.

NAME                                 STATUS   ROLES    AGE     VERSION
test-kdlxs-master-0                  Ready    master   19m     v1.22.1+bac83a5
test-kdlxs-master-1                  Ready    master   20m     v1.22.1+bac83a5
test-kdlxs-master-2                  Ready    master   25s     v1.22.1+bac83a5
test-kdlxs-worker-us-east-1a-dqr7r   Ready    worker   7m38s   v1.22.1+bac83a5
test-kdlxs-worker-us-east-1b-rdkhq   Ready    worker   8m32s   v1.22.1+bac83a5
test-kdlxs-worker-us-east-1b-ttqsr   Ready    worker   8m10s   v1.22.1+bac83a5
NAME                                 PHASE     TYPE            REGION	   ZONE         AGE
test-kdlxs-master-0                  Running   ecs.g6.xlarge   us-east-1   us-east-1b   21m
test-kdlxs-master-1                  Running   ecs.g6.xlarge   us-east-1   us-east-1a   21m
test-kdlxs-master-2                  Running   ecs.g6.xlarge   us-east-1   us-east-1b   21m
test-kdlxs-worker-us-east-1a-dqr7r   Running   ecs.g6.large    us-east-1   us-east-1a   14m
test-kdlxs-worker-us-east-1b-rdkhq   Running   ecs.g6.large    us-east-1   us-east-1b   14m

@lobziik
Copy link
Contributor

lobziik commented Nov 30, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lobziik, menglingwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2021
@openshift-merge-robot openshift-merge-robot merged commit e57b5e4 into openshift:main Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants