Skip to content

Comments

SPLAT-1129: create fixtures for VSphereProviderSpec zones#288

Merged
openshift-ci[bot] merged 3 commits intoopenshift:masterfrom
rvanderp3:cpms-vsphere-failure-domain
Oct 30, 2023
Merged

SPLAT-1129: create fixtures for VSphereProviderSpec zones#288
openshift-ci[bot] merged 3 commits intoopenshift:masterfrom
rvanderp3:cpms-vsphere-failure-domain

Conversation

@rvanderp3
Copy link
Contributor

@rvanderp3 rvanderp3 commented Jul 26, 2023

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 26, 2023
@openshift-ci openshift-ci bot requested review from RadekManak and elmiko July 26, 2023 22:32
@rvanderp3 rvanderp3 force-pushed the cpms-vsphere-failure-domain branch from ebab62d to ec44d7c Compare July 26, 2023 22:36
@rvanderp3 rvanderp3 mentioned this pull request Jul 26, 2023
Merged
6 tasks
@rvanderp3 rvanderp3 force-pushed the cpms-vsphere-failure-domain branch 3 times, most recently from 43e0cf3 to db61081 Compare July 27, 2023 15:12
@rvanderp3 rvanderp3 force-pushed the cpms-vsphere-failure-domain branch 3 times, most recently from 82ec723 to 69cb6a5 Compare August 15, 2023 18:26
@rvanderp3 rvanderp3 force-pushed the cpms-vsphere-failure-domain branch from 69cb6a5 to d825f3c Compare August 25, 2023 18:08
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 25, 2023
@rvanderp3 rvanderp3 force-pushed the cpms-vsphere-failure-domain branch 2 times, most recently from 135eeb2 to b7ef73d Compare August 25, 2023 19:24
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 25, 2023
@rvanderp3 rvanderp3 force-pushed the cpms-vsphere-failure-domain branch from b7ef73d to b952b21 Compare August 28, 2023 17:27
@rvanderp3 rvanderp3 force-pushed the cpms-vsphere-failure-domain branch 7 times, most recently from 1fcdf2d to bae928d Compare September 21, 2023 14:53
@rvanderp3 rvanderp3 force-pushed the cpms-vsphere-failure-domain branch from bae928d to d5c4bd2 Compare September 26, 2023 20:00
@rvanderp3 rvanderp3 force-pushed the cpms-vsphere-failure-domain branch from 26f4d8a to 777cfed Compare October 23, 2023 19:56
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 23, 2023
@rvanderp3 rvanderp3 force-pushed the cpms-vsphere-failure-domain branch 3 times, most recently from 91a0d05 to 7cdf756 Compare October 25, 2023 21:05
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 25, 2023
@rvanderp3 rvanderp3 changed the title WIP: create fixtures for VSphereProviderSpec zones SPLAT-1129: create fixtures for VSphereProviderSpec zones Oct 25, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 25, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 25, 2023 •
edited by openshift-ci bot
Loading

@rvanderp3: This pull request references SPLAT-1129 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 25, 2023
@rvanderp3 rvanderp3 force-pushed the cpms-vsphere-failure-domain branch 3 times, most recently from 608c0dd to 07a82f8 Compare October 25, 2023 21:39
@rvanderp3 rvanderp3 force-pushed the cpms-vsphere-failure-domain branch from 07a82f8 to ffc64ba Compare October 30, 2023 13:27
@rvanderp3
Copy link
Contributor Author

rvanderp3 commented Oct 30, 2023

/assign @vr4manta

@vr4manta
Copy link
Contributor

vr4manta commented Oct 30, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2023
elmiko
elmiko reviewed Oct 30, 2023
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense to me, just a quick question

testutils/resourcebuilder/config/v1/infrastructure.go
if failureDomains != nil {
infraBuilder.spec.PlatformSpec.VSphere.FailureDomains = *failureDomains
} else {
infraBuilder.spec.PlatformSpec.VSphere.FailureDomains = []configv1.VSpherePlatformFailureDomainSpec{
Copy link
Contributor

@elmiko elmiko Oct 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it make sense to use the failure domain builder here?

Copy link
Contributor Author

@rvanderp3 rvanderp3 Oct 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, i think it might. i'll take a look at that.

JoelSpeed
JoelSpeed reviewed Oct 30, 2023
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Oct 30, 2023

/hold for Mike's comment

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 30, 2023
@rvanderp3
Copy link
Contributor Author

rvanderp3 commented Oct 30, 2023

/hold cancel

discussed with Mike and this is ready to go.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 30, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 30, 2023

/retest-required

Remaining retests: 0 against base HEAD 217830d and 2 for PR HEAD ffc64ba in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2023

@rvanderp3: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-operator ffc64ba link false /test e2e-openstack-operator

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 4dcd987 into openshift:master Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@RadekManak RadekManak Awaiting requested review from RadekManak

+1 more reviewer

@elmiko elmiko elmiko left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@JoelSpeed JoelSpeed

@vr4manta vr4manta

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rvanderp3 @openshift-ci-robot @vr4manta @JoelSpeed @elmiko @openshift-merge-robot