Skip to content

Comments

No-JIRA: existing issue with unit test is fixed by syncedMUTEX#87

Closed
miyadav wants to merge 1 commit intoopenshift:mainfrom
miyadav:fixunittest
Closed

No-JIRA: existing issue with unit test is fixed by syncedMUTEX#87
miyadav wants to merge 1 commit intoopenshift:mainfrom
miyadav:fixunittest

Conversation

@miyadav
Copy link
Member

@miyadav miyadav commented Aug 20, 2025

@theobarberbany PTAL , it fixes the unit test failures

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 20, 2025
@openshift-ci-robot
Copy link

@miyadav: This pull request explicitly references no jira issue.

Details

In response to this:

@theobarberbany PTAL , it fixes the unit test failures

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from damdo and racheljpg August 20, 2025 05:49
@openshift-ci
Copy link

openshift-ci bot commented Aug 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nrb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@miyadav
Copy link
Member Author

miyadav commented Aug 20, 2025

/test unit

@openshift-ci
Copy link

openshift-ci bot commented Aug 20, 2025

@miyadav: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-commits 490e42d link false /test verify-commits

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@miyadav miyadav closed this by deleting the head repository Aug 20, 2025
@theobarberbany
Copy link

@miyadav, we can still use this - we just want to open the upstream PR first and then rename the commit here

UPSTREAM: upstream PR #: name, so we automatically drop the carry once it's merged upstream :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants