SPLAT-2220: tests/ote: extend tests for gate AWSServiceLBNetworkSecurityGroup#129
Conversation
|
Skipping CI for Draft Pull Request. |
|
/test ? |
|
/test e2e-aws-ovn-techpreview |
f4d8d01 to
5706aec
Compare
|
/test e2e-aws-ovn-techpreview |
5706aec to
04aaf73
Compare
|
/test e2e-aws-ovn-techpreview |
|
@mtulio: This pull request references SPLAT-2220 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
e4ae260 to
ddbfb75
Compare
|
@mtulio: This pull request references SPLAT-2220 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-aws-ovn-techpreview |
2d2fc64 to
f7872e8
Compare
|
Fixing delete and waiter flow: |
|
testing locally: Run: {
./aws-cloud-controller-manager-tests-ext run-test \
--names "[cloud-provider-aws-e2e-openshift] loadbalancer NLB [OCPFeatureGate:AWSServiceLBNetworkSecurityGroup] should have NLBSecurityGroupMode with 'Managed value in cloud-config [Suite:openshift/conformance/parallel]"
./aws-cloud-controller-manager-tests-ext run-test \
--names "[cloud-provider-aws-e2e-openshift] loadbalancer NLB [OCPFeatureGate:AWSServiceLBNetworkSecurityGroup] should create NLB service with security group attached [Suite:openshift/conformance/parallel]"
./aws-cloud-controller-manager-tests-ext run-test \
--names "[cloud-provider-aws-e2e-openshift] loadbalancer NLB [OCPFeatureGate:AWSServiceLBNetworkSecurityGroup] should have security groups attached to default ingress controller NLB [Suite:openshift/conformance/parallel]" \
./aws-cloud-controller-manager-tests-ext run-test \
--names "[cloud-provider-aws-e2e-openshift] loadbalancer NLB [OCPFeatureGate:AWSServiceLBNetworkSecurityGroup] should keep security groups attached after service update [Suite:openshift/conformance/parallel]"
./aws-cloud-controller-manager-tests-ext run-test \
--names "[cloud-provider-aws-e2e-openshift] loadbalancer NLB [OCPFeatureGate:AWSServiceLBNetworkSecurityGroup] should cleanup security groups when service is deleted [Suite:openshift/conformance/parallel]"
./aws-cloud-controller-manager-tests-ext run-test \
--names "[cloud-provider-aws-e2e-openshift] loadbalancer NLB [OCPFeatureGate:AWSServiceLBNetworkSecurityGroup] should have correct security group rules for service ports [Suite:openshift/conformance/parallel]"
} > ./e2e.logResult: ["[cloud-provider-aws-e2e-openshift] loadbalancer NLB [OCPFeatureGate:AWSServiceLBNetworkSecurityGroup] should have NLBSecurityGroupMode with 'Managed value in cloud-config [Suite:openshift/conformance/parallel]","passed"]
["[cloud-provider-aws-e2e-openshift] loadbalancer NLB [OCPFeatureGate:AWSServiceLBNetworkSecurityGroup] should create NLB service with security group attached [Suite:openshift/conformance/parallel]","passed"]
["[cloud-provider-aws-e2e-openshift] loadbalancer NLB [OCPFeatureGate:AWSServiceLBNetworkSecurityGroup] should have security groups attached to default ingress controller NLB [Suite:openshift/conformance/parallel]","passed"]
["[cloud-provider-aws-e2e-openshift] loadbalancer NLB [OCPFeatureGate:AWSServiceLBNetworkSecurityGroup] should keep security groups attached after service update [Suite:openshift/conformance/parallel]","passed"]
["[cloud-provider-aws-e2e-openshift] loadbalancer NLB [OCPFeatureGate:AWSServiceLBNetworkSecurityGroup] should cleanup security groups when service is deleted [Suite:openshift/conformance/parallel]","passed"]
["[cloud-provider-aws-e2e-openshift] loadbalancer NLB [OCPFeatureGate:AWSServiceLBNetworkSecurityGroup] should have correct security group rules for service ports [Suite:openshift/conformance/parallel]","passed"]
|
f7872e8 to
7a28fc6
Compare
|
/test e2e-aws-ovn-techpreview |
|
/test ? |
|
/test unit images verify-deps e2e-aws-ovn |
|
@mtulio: This pull request references SPLAT-2220 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@mtulio: This pull request references SPLAT-2220 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
6 tests are passing in the TP job, from junit: |
|
/verified by @mtulio #129 (comment) |
Update go.mod and vendoring for OTE binary (openshift-only)
e6ac253 to
f4b3797
Compare
f4b3797 to
9e04e96
Compare
|
/test e2e-aws-ovn-techpreview |
tests/aws-cloud-controller-manager-tests-ext/e2e/loadbalancer.go
Outdated
Show resolved
Hide resolved
9e04e96 to
1d636d7
Compare
|
/test e2e-aws-ovn-techpreview |
…Group Rename existing openshift e2e tests with feature name convention (OCPFeatureGate), as well adding more tests to cover the gate promotion.
1d636d7 to
76025dc
Compare
|
I have also updated the test /test e2e-aws-ovn-techpreview |
|
TP Job failed to install, unrelated. @JoelSpeed would you mind review again, please? Thanks /test e2e-aws-ovn-techpreview |
|
@mtulio: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@mtulio: This pull request references SPLAT-2220 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Validation:
-- Test groups: [2] Feature AWSServiceLBNetworkSecurityGroup specific tests |
|
/verified by @mtulio #129 (comment) |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified by @mtulio #129 (comment) |
|
@mtulio: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This change promotes the feature gate AWSServiceLBNetworkSecurityGroup from TechPreviewNoUpgrade to Default feature set. The tests covering this feature is added by openshift/cloud-provider-aws#129.
This change promotes the feature gate AWSServiceLBNetworkSecurityGroup from TechPreviewNoUpgrade to Default feature set. The tests covering this feature is added by openshift/cloud-provider-aws#129.
This change promotes the feature gate AWSServiceLBNetworkSecurityGroup from TechPreviewNoUpgrade to Default feature set. The tests covering this feature is added by openshift/cloud-provider-aws#129.
This change promotes the feature gate AWSServiceLBNetworkSecurityGroup from TechPreviewNoUpgrade to Default feature set on self-managed. Also the feature AWSServiceLBNetworkSecurityGroup is kept TP and DP on Hypershift while the implementation is finished on Hypershift. The tests covering this feature is added by openshift/cloud-provider-aws#129.
Changes:
Previous PR introducing tests: #126
Feature: https://issues.redhat.com/browse/OCPSTRAT-1553 / SPLAT-2220
Tests: