Skip to content

SPLAT-2337: tests/ote: Fix platform name in the spec build#121

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
mtulio:ote-set-provider
Nov 9, 2025
Merged

SPLAT-2337: tests/ote: Fix platform name in the spec build#121
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
mtulio:ote-set-provider

Conversation

@mtulio
Copy link
Copy Markdown

@mtulio mtulio commented Nov 3, 2025 •
edited
Loading

Set specs for AWS platform only. Fixes #117

Test results are available here: #121 (comment)

Follow up card to sanitize OTE commits is created at OCPCLOUD-3218

References:

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2025
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Nov 3, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@mtulio mtulio mentioned this pull request Nov 3, 2025
Merged
@mtulio
Copy link
Copy Markdown
Author

mtulio commented Nov 3, 2025

/testwith openshift/origin/main/e2e-aws-ovn openshift/origin#30235

@mtulio
Copy link
Copy Markdown
Author

mtulio commented Nov 6, 2025

/testwith openshift/origin/main/e2e-aws-ovn openshift/origin#30235

@mtulio
Copy link
Copy Markdown
Author

mtulio commented Nov 6, 2025

/testwith openshift/cloud-provider-aws/main/e2e-aws-ovn openshift/origin#30235 openshift/cluster-cloud-controller-manager-operator#391

@mtulio
Copy link
Copy Markdown
Author

mtulio commented Nov 6, 2025

Validations are performed in the origin PR openshift/origin#30235 (comment), it will be updated here.

Ideally this fix would be squashed with patch carried by 7b90bde

@mtulio
UPSTREAM: <carry>: Fix OTE ensuring AWS provider
aeccc0f 
Ensure specs is returning tests only in AWS cloud provider.

This commit must be squashed with 7b90bde
@mtulio mtulio marked this pull request as ready for review November 6, 2025 19:33
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 6, 2025
@openshift-ci openshift-ci bot requested review from chrischdi and mdbooth November 6, 2025 19:35
@mtulio mtulio changed the title tests/ote: Enforce platform name to the filter pipeline SPLAT-2337: tests/ote: Fix platform name in the spec build Nov 6, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 6, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Nov 6, 2025 •
edited by openshift-ci bot
Loading

@mtulio: This pull request references SPLAT-2337 which is a valid jira issue.

Details

In response to this:

Ref:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mtulio
Copy link
Copy Markdown
Author

mtulio commented Nov 6, 2025 •
edited
Loading

Tests in other platforms have been done in the origin PR openshift/origin#30235. More details PTAL in the PR description.

Platform Job ID/Step Results As Expected?
aws 1986444266678784000 / step All passed Yes
vsphere 1986476792151543808 / step All passed Yes

/assign @nrb

It would be nice to squash this commit with OTE to have a clean carry patch. I opened a card OCPCLOUD-3218 to track the squash reminder.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Nov 6, 2025 •
edited by openshift-ci bot
Loading

@mtulio: This pull request references SPLAT-2337 which is a valid jira issue.

Details

In response to this:

Set specs for AWS platform only.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Nov 6, 2025 •
edited by openshift-ci bot
Loading

@mtulio: This pull request references SPLAT-2337 which is a valid jira issue.

Details

In response to this:

Set specs for AWS platform only. Fixes #117

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Nov 6, 2025 •
edited by openshift-ci bot
Loading

@mtulio: This pull request references SPLAT-2337 which is a valid jira issue.

Details

In response to this:

Set specs for AWS platform only. Fixes #117

Test results are available here: #121 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Nov 6, 2025 •
edited by openshift-ci bot
Loading

@mtulio: This pull request references SPLAT-2337 which is a valid jira issue.

Details

In response to this:

Set specs for AWS platform only. Fixes #117

Test results are available here: #121 (comment)

Follow up card to sanitize OTE commits is created at OCPCLOUD-3218

References:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@huali9
Copy link
Copy Markdown

huali9 commented Nov 7, 2025

/verified by @huali9

Based on #121 (comment)

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 7, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Nov 7, 2025

@huali9: This PR has been marked as verified by @huali9.

Details

In response to this:

/verified by @huali9

Based on #121 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mtulio
Copy link
Copy Markdown
Author

mtulio commented Nov 7, 2025

/test e2e-hypershift

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Nov 7, 2025

@mtulio: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nrb
Copy link
Copy Markdown

nrb commented Nov 9, 2025

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2025
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Nov 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 70b9392 into openshift:main Nov 9, 2025
9 checks passed
@mtulio mtulio deleted the ote-set-provider branch November 9, 2025 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrischdi chrischdi Awaiting requested review from chrischdi

@mdbooth mdbooth Awaiting requested review from mdbooth

Assignees

@nrb nrb

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mtulio @openshift-ci-robot @huali9 @nrb