Support Updating Existing IngressController

[dustman9000]

This change depends on openshift/cluster-ingress-operator#472 (targeted for 4.7) and openshift/cluster-ingress-operator#482 (for 4.6).

This changes the way cloud-ingress-operator reconciles the IngressController CR and removes the need to delete all CRs before adding new CRs (which was highly disruptive).

Tested on a stage 4.6 cluster (drow-10-20-20) with both modified operators.

Update 4-13-21:
Changes to support mutable loadbalancer scope were pulled from the OCP 4.7 and 4.6 releases due to security concerns. Work has been restarted to address this in a more secure manner here: openshift/cluster-ingress-operator#582

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dustman9000
To complete the pull request process, please assign sam-nguyen7 after the PR has been reviewed.
You can assign the PR to them by writing /assign @sam-nguyen7 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Merging #118 (6c885c1) into master (35a1558) will increase coverage by 0.26%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
+ Coverage   29.24%   29.51%   +0.26%     
==========================================
  Files          24       24              
  Lines        1730     1701      -29     
==========================================
- Hits          506      502       -4     
+ Misses       1183     1162      -21     
+ Partials       41       37       -4     

Impacted Files	Coverage Δ
...ublishingstrategy/publishingstrategy_controller.go	24.34% <20.00%> (+0.91%)	⬆️

[dustman9000]

/hold for openshift/cluster-ingress-operator#472

[cblecker]

For clarity: this cannot merge until the entire fleet has been upgraded to include this fix.

[openshift-ci]

@dustman9000: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/lint	6c885c1	link	/test lint
ci/prow/validate	6c885c1	link	/test validate

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

@dustman9000: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dustman9000]

Since the upstream dependencies were removed from the 4.6 and 4.7 OCP releases due to a security concern and the new PR around supporting changing loadbalancer scope requires admin intervention to delete the service, I'm going to close this PR in favor of a new PR to support openshift/cluster-ingress-operator#582 later.