-
Notifications
You must be signed in to change notification settings - Fork 160
[release-4.12] PORTENABLE-526: operator: use a partial metadata watch for Namespaces #549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We only watch namespaces to react to their creation, and the only information we need about a namespace is its' name, so we can use a partial metadata watch to winnow down the size of our cache. Namespaces don't really store much in spec and status, so this effect is likely to not be enormous, but every bit helps. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
|
@openshift-cherrypick-robot: An error was encountered cloning bug for cherrypick for bug PORTENABLE-526 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details. Full error message.
request failed. Please analyze the request body for more details. Status code: 400: {"errorMessages":[],"errors":{"customfield_12318341":"Operation value must be a string"}}
Please contact an administrator to resolve this issue, then request a bug refresh with DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-4.12 #549 +/- ##
================================================
- Coverage 46.62% 46.59% -0.03%
================================================
Files 94 94
Lines 10053 10058 +5
================================================
Hits 4687 4687
- Misses 4807 4812 +5
Partials 559 559
|
|
/close |
|
@stevekuznetsov: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #546
/assign stevekuznetsov