Skip to content

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Sep 8, 2022

This was added in
openshift/cluster-version-operator#821 to allow
more featuresets and allow for a future migration to include actual gates

/cc @wking

@openshift-ci openshift-ci bot requested a review from wking September 8, 2022 17:04
@akhil-rane
Copy link
Contributor

/lgtm

@akhil-rane
Copy link
Contributor

@akhil-rane
Copy link
Contributor

/assign @jeana-redhat @jianping-shu @davemulford

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akhil-rane, deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2022
@jeana-redhat
Copy link

jeana-redhat commented Sep 8, 2022

  • I think this means all instances in the user docs (there are not a ton) of release.openshift.io/feature-gate need to be updated to release.openshift.io/feature-set - is that correct?
  • Is this OCP 4.12+?

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #490 (d3ce03b) into master (7bc6617) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #490   +/-   ##
=======================================
  Coverage   46.25%   46.25%           
=======================================
  Files          94       94           
  Lines        9769     9769           
=======================================
  Hits         4519     4519           
  Misses       4714     4714           
  Partials      536      536           

@jianping-shu
Copy link

Build image w/ cluster bot.
Tested w/ OCP-48059 , annotation in CredentialsRequest is "feature-set".
[cloud-user@preserve-for-hive-test credrequests-aws]$ grep TechPreviewNoUpgrade *
0000_30_cluster-api_00_credentials-request.yaml: release.openshift.io/feature-set: TechPreviewNoUpgrade

@jianping-shu
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 9, 2022
@davemulford
Copy link

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Sep 9, 2022
@jeana-redhat
Copy link

Based on @wking's 👍 I am approving with the impact understood as just s/release.openshift.io/feature-gate/release.openshift.io/feature-set in 4.12+ docs

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Sep 9, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 7bc6617 and 2 for PR HEAD d3ce03b in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2022

@deads2k: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 2f31f28 into openshift:master Sep 9, 2022
@jeana-redhat
Copy link

@deads2k does there happen to be a dev-side Jira card that captures this? Just looking to see if there is a thing I can tie a docs card to.

ming1013 pushed a commit to ming1013/cloud-credential-operator that referenced this pull request Dec 15, 2025
update to release.openshift.io/feature-set to match OCP 4.12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants