Bug 2034484: Library go bump by eggfoobar · Pull Request #434 · openshift/cloud-credential-operator

eggfoobar · 2021-12-15T21:00:31Z

Bumping the library-go dependency to latest, this should take advantage of performance improvements in this PR.

Changes:

bump: updated library-go to latest
updated to pass context down to calling library-go functions
updated static resource apply to use cache improvements
updated method call for setloglevel

xref: https://issues.redhat.com/browse/CNF-2808

jerpeter1 · 2021-12-22T14:23:54Z

/retest-required

eggfoobar · 2021-12-22T17:46:12Z

Unit tests are failing at this point, there were some changes with the fake package but from what I could gather nothing that would cause this behavior. After debugging and stepping through the test it seems like the reconcile is behaving correctly, at this point I don't have the context to say if the unit test is broken or if there's a logic issue.

@joelddiaz is there any context you can provide on the expected behavior?

--- FAIL: TestCredentialsRequestReconcile (0.37s)
    --- FAIL: TestCredentialsRequestReconcile/existing_passthrough_credential (0.01s)
        credentialsrequest_controller_test.go:650: 
            	Error Trace:	credentialsrequest_controller_test.go:650
            	            				credentialsrequest_controller_test.go:1360
            	Error:      	Not equal: 
            	            	expected: "FAKEAWSACCESSKEYID"
            	            	actual  : "rootaccesskey"
            	            	
            	            	Diff:
            	            	--- Expected
            	            	+++ Actual
            	            	@@ -1 +1 @@
            	            	-FAKEAWSACCESSKEYID
            	            	+rootaccesskey
            	Test:       	TestCredentialsRequestReconcile/existing_passthrough_credential
        credentialsrequest_controller_test.go:652: 
            	Error Trace:	credentialsrequest_controller_test.go:652
            	            				credentialsrequest_controller_test.go:1360
            	Error:      	Not equal: 
            	            	expected: "KEEPITSECRET"
            	            	actual  : "rootsecretkey"
            	            	
            	            	Diff:
            	            	--- Expected
            	            	+++ Actual
            	            	@@ -1 +1 @@
            	            	-KEEPITSECRET
            	            	+rootsecretkey
            	Test:       	TestCredentialsRequestReconcile/existing_passthrough_credential
    --- FAIL: TestCredentialsRequestReconcile/existing_passthrough_credential_bypassing_simulations (0.01s)
        credentialsrequest_controller_test.go:687: 
            	Error Trace:	credentialsrequest_controller_test.go:687
            	            				credentialsrequest_controller_test.go:1360
            	Error:      	Not equal: 
            	            	expected: "FAKEAWSACCESSKEYID"
            	            	actual  : "rootaccesskey"
            	            	
            	            	Diff:
            	            	--- Expected
            	            	+++ Actual
            	            	@@ -1 +1 @@
            	            	-FAKEAWSACCESSKEYID
            	            	+rootaccesskey
            	Test:       	TestCredentialsRequestReconcile/existing_passthrough_credential_bypassing_simulations
        credentialsrequest_controller_test.go:689: 
            	Error Trace:	credentialsrequest_controller_test.go:689
            	            				credentialsrequest_controller_test.go:1360
            	Error:      	Not equal: 
            	            	expected: "KEEPITSECRET"
            	            	actual  : "rootsecretkey"
            	            	
            	            	Diff:
            	            	--- Expected
            	            	+++ Actual
            	            	@@ -1 +1 @@
            	            	-KEEPITSECRET
            	            	+rootsecretkey
            	Test:       	TestCredentialsRequestReconcile/existing_passthrough_credential_bypassing_simulations

codecov · 2021-12-23T17:22:15Z

Codecov Report

Merging #434 (8086425) into master (895e9c1) will decrease coverage by 0.93%.
The diff coverage is 12.50%.

@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
- Coverage   46.35%   45.41%   -0.94%     
==========================================
  Files          92       92              
  Lines        9206     9229      +23     
==========================================
- Hits         4267     4191      -76     
- Misses       4418     4532     +114     
+ Partials      521      506      -15

Impacted Files	Coverage Δ
pkg/assets/bootstrap/bindata.go	`23.85% <ø> (ø)`
pkg/operator/awspodidentity/controller.go	`0.00% <0.00%> (ø)`
pkg/operator/loglevel/controller.go	`49.15% <100.00%> (ø)`
.../cmd/provisioning/alibabacloud/delete-ram-users.go	`7.61% <0.00%> (-29.50%)`	⬇️
pkg/alibabacloud/mock/client_generated.go	`54.00% <0.00%> (-22.60%)`	⬇️
pkg/gcp/actuator/actuator.go	`53.39% <0.00%> (-3.07%)`	⬇️
pkg/azure/actuator.go	`53.95% <0.00%> (-2.88%)`	⬇️
pkg/alibabacloud/client.go	`0.00% <0.00%> (ø)`
.../cmd/provisioning/alibabacloud/create-ram-users.go	`39.01% <0.00%> (+0.33%)`	⬆️

ggiguash · 2021-12-27T09:13:54Z

/retest-required

ggiguash · 2022-01-04T16:25:44Z

/retest-required

joelddiaz · 2022-01-05T16:48:53Z

@eggfoobar #438 has merged so you should re-base on top of that/master now

updated library go to latest Signed-off-by: ehila <ehila@redhat.com> upkeep: ran make update Signed-off-by: ehila <ehila@redhat.com>

Signed-off-by: ehila <ehila@redhat.com>

Signed-off-by: ehila <ehila@redhat.com> fix: unit test for cleanup stale state Fake client now respects finalizers, if any are present delete functionality will simulate real cluster resource delete More info: kubernetes-sigs/controller-runtime#1399 Signed-off-by: ehila <ehila@redhat.com> fix: updated unit tests mock object with max call Signed-off-by: ehila <ehila@redhat.com>

eggfoobar · 2022-01-05T20:39:08Z

/retest-required

eggfoobar · 2022-01-06T07:52:54Z

/retest-required

eggfoobar · 2022-01-06T22:17:06Z

/retest-required

openshift-ci · 2022-01-07T14:18:46Z

@eggfoobar: This pull request references Bugzilla bug 2034484, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (jhou@redhat.com), skipping review request.

Details

In response to this:

Bug 2034484: Library go bump

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

eggfoobar · 2022-01-08T20:02:24Z

/retest-required

ggiguash · 2022-01-12T14:22:36Z

/retest-required

eggfoobar · 2022-01-12T16:46:04Z

/assign @joelddiaz

2uasimojo · 2022-01-12T20:30:54Z

+				fakeClient = fake.NewClientBuilder().WithRuntimeObjects(test.existingSecret).Build()
 			} else {
-				fakeClient = fake.NewFakeClient()
+				fakeClient = fake.NewClientBuilder().WithRuntimeObjects().Build()


Is

Suggested change

fakeClient = fake.NewClientBuilder().WithRuntimeObjects().Build()

fakeClient = fake.NewClientBuilder().Build()

a legitimate way to spell this?

Good catch, updated to remove redundant builder function call

joelddiaz · 2022-01-12T20:38:55Z

/test e2e-gcp
/test e2e-azure

joelddiaz · 2022-01-12T21:35:02Z

 			Name:        testStaleCRName,
 			Namespace:   testNamespace,
-			Finalizers:  []string{minterv1.FinalizerDeprovision},
+			Finalizers:  []string{},


Rather than this, can we leave the Finalizer, but change the codepath that verifies deltion from assert.Nil() to assert.NotNil(t, cr.DeletionTimestamp, ...) specifically:

- assert.Nil(t, cr, "expected credentials request to be deleted") + assert.NotNil(t, cr.DeletionTimestamp, "expected credentials request to be marked for deletion")

Absolutely, updated

updated unit test to retain FinalizerDeprovision for cleanup_controller_test.go modified client builder to remove unneeded builder function call Signed-off-by: ehila <ehila@redhat.com>

joelddiaz

/lgtm

openshift-ci · 2022-01-13T14:01:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eggfoobar, joelddiaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [joelddiaz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2022-01-13T14:34:07Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-01-13T15:26:04Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2022-01-13T16:25:20Z

@eggfoobar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure-upgrade	`59c3527`	link	false	`/test e2e-azure-upgrade`
ci/prow/e2e-gcp	`0212d37`	link	false	`/test e2e-gcp`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2022-01-13T16:26:56Z

@eggfoobar: Bugzilla bug 2034484 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

Details

In response to this:

Bug 2034484: Library go bump

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Bug 2034484: Library go bump

openshift-ci Bot requested review from joelddiaz and suhanime December 15, 2021 21:03

eggfoobar force-pushed the library_go_bump branch 3 times, most recently from e6da711 to 59c3527 Compare December 21, 2021 18:49

eggfoobar force-pushed the library_go_bump branch from 70d5915 to 2998451 Compare December 23, 2021 15:30

eggfoobar added 3 commits January 5, 2022 12:35

feat: library-go bump

417ac63

updated library go to latest Signed-off-by: ehila <ehila@redhat.com> upkeep: ran make update Signed-off-by: ehila <ehila@redhat.com>

feat: updated method calls to match signatures in updated library-go

ac33b1d

Signed-off-by: ehila <ehila@redhat.com>

eggfoobar force-pushed the library_go_bump branch from 2998451 to 0212d37 Compare January 5, 2022 17:46

eggfoobar changed the title ~~Library go bump~~ Bug 2034484: Library go bump Jan 7, 2022

openshift-ci Bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Jan 7, 2022

openshift-ci Bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 7, 2022

openshift-ci Bot mentioned this pull request Jan 7, 2022

Bug 2034484: Library go bump openshift/cluster-version-operator#716

Merged

openshift-ci Bot mentioned this pull request Jan 10, 2022

Bug 2034484: Library go bump openshift/cluster-csi-snapshot-controller-operator#107

Merged

openshift-ci Bot assigned joelddiaz Jan 12, 2022

2uasimojo reviewed Jan 12, 2022

View reviewed changes

joelddiaz reviewed Jan 12, 2022

View reviewed changes

tests: unit test update

8086425

updated unit test to retain FinalizerDeprovision for cleanup_controller_test.go modified client builder to remove unneeded builder function call Signed-off-by: ehila <ehila@redhat.com>

joelddiaz reviewed Jan 13, 2022

View reviewed changes

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2022

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2022

openshift-merge-robot merged commit 9ee7dea into openshift:master Jan 13, 2022

ming1013 pushed a commit to ming1013/cloud-credential-operator that referenced this pull request Dec 15, 2025

Merge pull request openshift#434 from eggfoobar/library_go_bump

1172c90

Bug 2034484: Library go bump

	fakeClient = fake.NewClientBuilder().WithRuntimeObjects().Build()
	fakeClient = fake.NewClientBuilder().Build()

Conversation

eggfoobar commented Dec 15, 2021 • edited by joelddiaz Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jerpeter1 commented Dec 22, 2021

Uh oh!

eggfoobar commented Dec 22, 2021

Uh oh!

codecov Bot commented Dec 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ggiguash commented Dec 27, 2021

Uh oh!

ggiguash commented Jan 4, 2022

Uh oh!

joelddiaz commented Jan 5, 2022

Uh oh!

eggfoobar commented Jan 5, 2022

Uh oh!

eggfoobar commented Jan 6, 2022

Uh oh!

eggfoobar commented Jan 6, 2022

Uh oh!

openshift-ci Bot commented Jan 7, 2022

Uh oh!

eggfoobar commented Jan 8, 2022

Uh oh!

ggiguash commented Jan 12, 2022

Uh oh!

eggfoobar commented Jan 12, 2022

Uh oh!

2uasimojo Jan 12, 2022

Choose a reason for hiding this comment

Uh oh!

eggfoobar Jan 13, 2022

Choose a reason for hiding this comment

Uh oh!

joelddiaz commented Jan 12, 2022

Uh oh!

joelddiaz Jan 12, 2022

Choose a reason for hiding this comment

Uh oh!

eggfoobar Jan 13, 2022

Choose a reason for hiding this comment

Uh oh!

joelddiaz left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Jan 13, 2022

Uh oh!

openshift-bot commented Jan 13, 2022

Uh oh!

openshift-bot commented Jan 13, 2022

Uh oh!

openshift-ci Bot commented Jan 13, 2022

Uh oh!

openshift-ci Bot commented Jan 13, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

eggfoobar commented Dec 15, 2021 •

edited by joelddiaz

Loading

codecov Bot commented Dec 23, 2021 •

edited

Loading