Azure vendoring update #426

joelddiaz · 2021-11-29T16:29:57Z

update github.com/Azure/azure-sdk-for-go and github.com/Azure/go-autorest vendoring

xref: https://issues.redhat.com/browse/CCO-173

codecov · 2021-11-29T16:40:11Z

Codecov Report

Merging #426 (7970972) into master (64bab70) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #426   +/-   ##
=======================================
  Coverage   46.39%   46.39%           
=======================================
  Files          94       94           
  Lines        9688     9688           
=======================================
  Hits         4495     4495           
  Misses       4612     4612           
  Partials      581      581

joelddiaz · 2021-11-29T17:13:55Z

/test e2e-azure

joelddiaz · 2021-11-29T19:08:58Z

/assign @akhil-rane

akhil-rane

/lgtm

openshift-bot · 2021-11-29T23:16:19Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-29T23:40:21Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

joelddiaz · 2021-11-30T13:26:02Z

@akhil-rane had to re-base after another PR merged

akhil-rane · 2021-11-30T14:48:44Z

/lgtm

joelddiaz · 2021-12-06T16:26:25Z

/assign @lwan-wanglin @jeana-redhat @sferich888
This is just updating some of our Azure golang dependencies. No code / feature changes here.

lwan-wanglin · 2021-12-07T04:50:03Z

run a basic test, no regression found https://mastern-jenkins-csb-openshift-qe.apps.ocp-c1.prod.psi.redhat.com/job/ocp-common/job/Runner/245695/console
/label qe-approved

jeana-redhat · 2021-12-09T19:03:17Z

/label docs-approved

go get github.com/Azure/azure-sdk-for-go go mod vendor ; go mod tidy commit

go get github.com/Azure/go-autorest/autorest go get github.com/Azure/go-autorest/autorest/adal go get github.com/Azure/go-autorest/autorest/azure/auth go get github.com/Azure/go-autorest/autorest/to go get github.com/Azure/go-autorest/autorest/azure/cli go get github.com/Azure/go-autorest/autorest/validation followed by go mod vendor ; go mod tidy and committing the changes

openshift-ci · 2021-12-09T21:20:50Z

@joelddiaz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-upgrade	`7970972`	link	true	`/test e2e-upgrade`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

joelddiaz · 2021-12-16T20:31:35Z

@akhil-rane this needs another lgtm
@sferich888 this needs the px-approved review

joelddiaz · 2021-12-16T20:34:44Z

/test e2e-upgrade

sferich888 · 2021-12-17T15:13:48Z

/label px-approved

akhil-rane · 2021-12-17T15:36:27Z

/lgtm

openshift-ci · 2021-12-17T15:37:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akhil-rane, joelddiaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [akhil-rane,joelddiaz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Azure vendoring update

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2021

openshift-ci bot requested review from 2uasimojo and suhanime November 29, 2021 16:38

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2021

joelddiaz force-pushed the azure-update branch from 2aaa383 to 46abf5d Compare November 29, 2021 16:41

openshift-ci bot assigned akhil-rane Nov 29, 2021

joelddiaz changed the title ~~WIP: Azure vendoring update~~ Azure vendoring update Nov 29, 2021

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2021

akhil-rane reviewed Nov 29, 2021

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2021

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 30, 2021

joelddiaz force-pushed the azure-update branch from 46abf5d to b4b1b36 Compare November 30, 2021 13:25

openshift-ci bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 30, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2021

openshift-ci bot assigned jeana-redhat, lwan-wanglin and sferich888 Dec 6, 2021

openshift-ci bot added qe-approved Signifies that QE has signed off on this PR needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 7, 2021

openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Dec 9, 2021

Joel Diaz added 2 commits December 9, 2021 14:29

update azure-sdk-for-go

9af2273

go get github.com/Azure/azure-sdk-for-go go mod vendor ; go mod tidy commit

joelddiaz force-pushed the azure-update branch from b4b1b36 to 7970972 Compare December 9, 2021 19:30

openshift-ci bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 9, 2021

joelddiaz mentioned this pull request Dec 16, 2021

Azure passthrough #433

Merged

5 tasks

openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Dec 17, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2021

openshift-merge-robot merged commit d3af1d3 into openshift:master Dec 17, 2021

ming1013 pushed a commit to ming1013/cloud-credential-operator that referenced this pull request Dec 15, 2025

Merge pull request openshift#426 from joelddiaz/azure-update

2af548e

Azure vendoring update

Azure vendoring update #426

Azure vendoring update #426

Uh oh!

Conversation

joelddiaz commented Nov 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Nov 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

joelddiaz commented Nov 29, 2021

Uh oh!

joelddiaz commented Nov 29, 2021

Uh oh!

akhil-rane left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-bot commented Nov 29, 2021

Uh oh!

openshift-bot commented Nov 29, 2021

Uh oh!

joelddiaz commented Nov 30, 2021

Uh oh!

akhil-rane commented Nov 30, 2021

Uh oh!

joelddiaz commented Dec 6, 2021

Uh oh!

lwan-wanglin commented Dec 7, 2021

Uh oh!

jeana-redhat commented Dec 9, 2021

Uh oh!

openshift-ci bot commented Dec 9, 2021

Uh oh!

joelddiaz commented Dec 16, 2021

Uh oh!

joelddiaz commented Dec 16, 2021

Uh oh!

sferich888 commented Dec 17, 2021

Uh oh!

akhil-rane commented Dec 17, 2021

Uh oh!

openshift-ci bot commented Dec 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

joelddiaz commented Nov 29, 2021 •

edited

Loading

codecov bot commented Nov 29, 2021 •

edited

Loading