Skip to content

WIP: migrate to using openshift/api/cloudcredential API #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
joelddiaz wants to merge 3 commits into from
Closed

WIP: migrate to using openshift/api/cloudcredential API #224

joelddiaz wants to merge 3 commits into from

Conversation

@joelddiaz
Copy link
Contributor

@joelddiaz joelddiaz commented Jul 9, 2020

Vendor openshift/api to use the API defnitions located there.

Update import paths as needed.

Remove pkg/apis/cloudcredential API definition from this repo.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 9, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 9, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelddiaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2020
@joelddiaz
Copy link
Contributor Author

joelddiaz commented Jul 9, 2020

/hold
would need to revendor once openshift/api#683 merges

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 9, 2020
Joel Diaz added 2 commits July 9, 2020 16:02
migrate to using openshift/api/cloudcredential API
e0c9c8b
remove CRD generation and now unused pkg/apis
e218533 
Remove unused hack scripts, and copy over the generated CRD from openshift/api/cloudcredential/v1

`cp vendor/github.com/openshift/api/cloudcredential/v1/000_10_config-operator_01_credentialsrequest.crd.yaml ./manifests/00-crd.yaml`

NOTE: there is no diff from the copy (which is a good thing!)
@joelddiaz
Copy link
Contributor Author

joelddiaz commented Jul 10, 2020

/test e2e-aws-upgrade

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 16, 2020

@joelddiaz: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-upgrade e218533 link /test e2e-aws-upgrade
ci/prow/e2e-upgrade e218533 link /test e2e-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@twiest twiest removed their request for review October 1, 2020 18:19
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 30, 2020

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 30, 2020
@staebler
Copy link
Contributor

staebler commented Jan 25, 2021

/uncc

@openshift-ci-robot openshift-ci-robot removed the request for review from staebler January 25, 2021 16:18
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 24, 2021

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 24, 2021
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 26, 2021

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 26, 2021

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joelddiaz @openshift-ci-robot @openshift-bot @staebler