pkg/aws: allow users to create a client from IAM client #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
users like openshift installer configure AWS clients with properties like - configure the max retires for the client to wait longer for throttle errors. - configure the service endpoint resolver in larger ecosystem of other AWS APIs - configure and control the user agent sent with AWS requests. The existing method doesn't allow the freedom mentioned above and is too restrictive to use as lib.
This was referenced Mar 15, 2020
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, joelddiaz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
abhinavdahiya
added a commit
to abhinavdahiya/installer
that referenced
this pull request
Mar 16, 2020
``` $ go version go version go1.14 linux/amd64 $ go mod edit -require github.com/openshift/cloud-credential-operator@master $ go mod tidy warning: ignoring symlink /home/adahiya/go/src/github.com/openshift/installer/pkg/asset/store/data go: downloading github.com/openshift/cloud-credential-operator v0.0.0-20200316201045-d10080b52c9e $ go mod vendor ``` brings in changes from openshift/cloud-credential-operator#167
ming1013
pushed a commit
to ming1013/cloud-credential-operator
that referenced
this pull request
Dec 15, 2025
pkg/aws: allow users to create a client from IAM client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
users like openshift installer configure AWS clients with properties like
The existing method doesn't allow the freedom mentioned above and is too restrictive to use as lib.