Add manifest annotations for hosted deployment exclusions#135
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Nov 15, 2019
Merged
Add manifest annotations for hosted deployment exclusions#135openshift-merge-robot merged 1 commit intoopenshift:masterfrom
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
size/XS
Contributor
|
@csrwng so how do in-cluster components get cloud credentials for the hosted control-plane environment? |
Contributor
Author
|
For now they don’t. IBM public cloud uses its own kube cloud provider for storage and lb’s. And they do their own machine management. |
Contributor
|
it looks like we're good to merge after the format of the annotation is finalized |
Contributor
Author
|
@joelddiaz the CVO PR has merged, this should be good to go |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csrwng, joelddiaz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ming1013
pushed a commit
to ming1013/cloud-credential-operator
that referenced
this pull request
Dec 15, 2025
Add manifest annotations for hosted deployment exclusions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables the CVO to exclude manifests in an externally hosted control plane deployment
See openshift/cluster-version-operator#252