Skip to content

OPNET-415: Revert the revert "Update openshift/api for new Infrastructure and Network fields"#270

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
mkowalski:OPNET-415
Jan 4, 2024
Merged

OPNET-415: Revert the revert "Update openshift/api for new Infrastructure and Network fields"#270
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
mkowalski:OPNET-415

Conversation

@mkowalski
Copy link
Contributor

@mkowalski mkowalski commented Jan 4, 2024

Reverts #267 which reverted #264.

OpenShift API change has landed in openshift/api#1695.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 4, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 4, 2024 •
edited by openshift-ci bot
Loading

@mkowalski: This pull request references OPNET-415 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Reverts #267 which reverted #264.

OpenShift API change has landed in openshift/api#1695.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mkowalski
Copy link
Contributor Author

mkowalski commented Jan 4, 2024

/cc @JoelSpeed

@openshift-ci openshift-ci bot requested review from JoelSpeed and deads2k January 4, 2024 12:10
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 4, 2024

@mkowalski: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Jan 4, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, mkowalski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 223261f into openshift:master Jan 4, 2024
@mkowalski mkowalski deleted the OPNET-415 branch January 4, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@JoelSpeed JoelSpeed

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mkowalski @openshift-ci-robot @JoelSpeed