Skip to content

Conversation

@QiWang19
Copy link
Member

@QiWang19 QiWang19 commented Sep 15, 2021

Update openshift/api to latest master commit version to include ImageContenPolicy API that was added in openshift/api#874 to support allowMirrorByTags.

API enhancement: openshift/enhancements#690
REF: https://issues.redhat.com/browse/OCPNODE-521

Signed-off-by: Qi Wang qiwan@redhat.com

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 15, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 15, 2021
@openshift-ci openshift-ci bot requested review from soltysh and sttts September 15, 2021 15:21
@QiWang19 QiWang19 marked this pull request as ready for review September 15, 2021 15:22
@QiWang19 QiWang19 marked this pull request as draft September 15, 2021 15:22
@QiWang19
Copy link
Member Author

/test all

1 similar comment
@QiWang19
Copy link
Member Author

/test all

@QiWang19
Copy link
Member Author

/test all

Signed-off-by: Qi Wang <qiwan@redhat.com>
Signed-off-by: Qi Wang <qiwan@redhat.com>
@QiWang19 QiWang19 changed the title [WIP] Update ImageContentSourcePolicy Update openshift/api version to include ImageContentPolicy Sep 24, 2021
@QiWang19 QiWang19 marked this pull request as ready for review September 24, 2021 16:23
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 24, 2021
@QiWang19
Copy link
Member Author

/test all

@QiWang19
Copy link
Member Author

@soltysh @sttts Could you review?

@sttts
Copy link
Contributor

sttts commented Sep 27, 2021

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 27, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: QiWang19, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2021
@openshift-merge-robot openshift-merge-robot merged commit 067cd72 into openshift:master Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants