OTA-915: metadata-helper/src/config/cli: Expose --signatures.dir

[wking]

Exposing the config setting from fb20669 (#794) as a command-line option, so folks can pass it though without having to drop into TOML or hitting:

2023-11-08T00:01:57.621922383Z [2023-11-08T00:01:57Z INFO  metadata_helper] application settings:
2023-11-08T00:01:57.621922383Z     AppSettings {
2023-11-08T00:01:57.621922383Z         verbosity: Trace,
2023-11-08T00:01:57.621922383Z         address: ::,
2023-11-08T00:01:57.621922383Z         port: 8082,
2023-11-08T00:01:57.621922383Z         path_prefix: "/api/upgrades_info",
2023-11-08T00:01:57.621922383Z         status_address: ::,
2023-11-08T00:01:57.621922383Z         status_port: 9082,
2023-11-08T00:01:57.621922383Z         signatures_dir: "",
2023-11-08T00:01:57.621922383Z         tracing_endpoint: None,
2023-11-08T00:01:57.621922383Z         backlog: 10,
2023-11-08T00:01:57.621922383Z         max_connections: 10,
2023-11-08T00:01:57.621922383Z         max_connection_rate: 64,
2023-11-08T00:01:57.621922383Z         keep_alive: None,
2023-11-08T00:01:57.621922383Z         client_timeout: 5s,
2023-11-08T00:01:57.621922383Z     }
2023-11-08T00:01:57.622031074Z [2023-11-08T00:01:57Z INFO  metadata_helper] signatures data directory not provided, using /tmp/.tmp2r89fA

[openshift-ci-robot]

@wking: This pull request references OTA-915 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Exposing the config setting from fb20669 (#794) as a command-line option, so folks can pass it though without having to drop into TOML or hitting:

2023-11-08T00:01:57.621922383Z [2023-11-08T00:01:57Z INFO  metadata_helper] application settings:
2023-11-08T00:01:57.621922383Z     AppSettings {
2023-11-08T00:01:57.621922383Z         verbosity: Trace,
2023-11-08T00:01:57.621922383Z         address: ::,
2023-11-08T00:01:57.621922383Z         port: 8082,
2023-11-08T00:01:57.621922383Z         path_prefix: "/api/upgrades_info",
2023-11-08T00:01:57.621922383Z         status_address: ::,
2023-11-08T00:01:57.621922383Z         status_port: 9082,
2023-11-08T00:01:57.621922383Z         signatures_dir: "",
2023-11-08T00:01:57.621922383Z         tracing_endpoint: None,
2023-11-08T00:01:57.621922383Z         backlog: 10,
2023-11-08T00:01:57.621922383Z         max_connections: 10,
2023-11-08T00:01:57.621922383Z         max_connection_rate: 64,
2023-11-08T00:01:57.621922383Z         keep_alive: None,
2023-11-08T00:01:57.621922383Z         client_timeout: 5s,
2023-11-08T00:01:57.621922383Z     }
2023-11-08T00:01:57.622031074Z [2023-11-08T00:01:57Z INFO  metadata_helper] signatures data directory not provided, using /tmp/.tmp2r89fA

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[PratikMahajan]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PratikMahajan, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [PratikMahajan,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@wking: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.