-
Notifications
You must be signed in to change notification settings - Fork 60
OTA-946: openshift_secondary_metadata_parser: Support graph-data 1.2.0 #876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTA-946: openshift_secondary_metadata_parser: Support graph-data 1.2.0 #876
Conversation
openshift/cincinnati-graph-data@9e9e97cf2a (OTA-949: README: Define a 1.2.0 filesystem schema for release signatures, 2023-04-19, openshift/cincinnati-graph-data#3509) defined that graph-data version, adding only: signatures/{algorithm}/{digest}/signature-{number} Cincinnati learned how to process those paths already in fb20669 (add signatures serving module to metadata_helper, 2023-06-26, openshift#794). This commit just catches up the supported-version set, to avoid failing like [1]: $ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_cincinnati-operator/176/pull-ci-openshift-cincinnati-operator-master-operator-e2e-hypershift-local-graph-data/1722001220597452800/artifacts/operator-e2e-hypershift-local-graph-data/e2e-test/artifacts/inspect/namespaces/openshift-updateservice/pods/example-5cd78cdf8b-vqcgv/graph-builder/graph-builder/logs/current.log | tail -n3 2023-11-07T21:50:33.646877602Z [2023-11-07T21:50:33Z TRACE cincinnati::plugins] Running next plugin 'openshift-secondary-metadata-parse' 2023-11-07T21:50:33.657154577Z [2023-11-07T21:50:33Z ERROR graph_builder::graph] unrecognized graph-data version 1.2.0 2023-11-07T21:50:33.657154577Z ; supported versions: ["1.0.0", "1.1.0"] when run against graph-data that declares itself to use the new version. [1]: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cincinnati-operator/176/pull-ci-openshift-cincinnati-operator-master-operator-e2e-hypershift-local-graph-data/1722001220597452800
|
@wking: This pull request references OTA-946 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
To avoid tripping over an overly strict graph-data parser until [1] lands. [1]: openshift/cincinnati#876
To avoid tripping over an overly strict graph-data parser until [1] lands. [1]: openshift/cincinnati#876
|
/retest-required |
|
@wking: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
To avoid tripping over an overly strict graph-data parser until [1] lands. [1]: openshift/cincinnati#876
To avoid tripping over an overly strict graph-data parser until [1] lands. [1]: openshift/cincinnati#876
PratikMahajan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: PratikMahajan, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift/cincinnati-graph-data@9e9e97cf2a (openshift/cincinnati-graph-data#3509) defined that graph-data version, adding only:
Cincinnati learned how to process those paths already in fb20669 (#794) and #816. This commit just catches up the supported-version set, to avoid failing like:
when run against graph-data that declares itself to use the new version.