Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Nov 7, 2023

openshift/cincinnati-graph-data@9e9e97cf2a (openshift/cincinnati-graph-data#3509) defined that graph-data version, adding only:

signatures/{algorithm}/{digest}/signature-{number}

Cincinnati learned how to process those paths already in fb20669 (#794) and #816. This commit just catches up the supported-version set, to avoid failing like:

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_cincinnati-operator/176/pull-ci-openshift-cincinnati-operator-master-operator-e2e-hypershift-local-graph-data/1722001220597452800/artifacts/operator-e2e-hypershift-local-graph-data/e2e-test/artifacts/inspect/namespaces/openshift-updateservice/pods/example-5cd78cdf8b-vqcgv/graph-builder/graph-builder/logs/current.log | tail -n3
2023-11-07T21:50:33.646877602Z [2023-11-07T21:50:33Z TRACE cincinnati::plugins] Running next plugin 'openshift-secondary-metadata-parse'
2023-11-07T21:50:33.657154577Z [2023-11-07T21:50:33Z ERROR graph_builder::graph] unrecognized graph-data version 1.2.0
2023-11-07T21:50:33.657154577Z     ; supported versions: ["1.0.0", "1.1.0"]

when run against graph-data that declares itself to use the new version.

openshift/cincinnati-graph-data@9e9e97cf2a (OTA-949: README: Define a
1.2.0 filesystem schema for release signatures, 2023-04-19,
openshift/cincinnati-graph-data#3509) defined that graph-data version,
adding only:

  signatures/{algorithm}/{digest}/signature-{number}

Cincinnati learned how to process those paths already in fb20669
(add signatures serving module to metadata_helper, 2023-06-26, openshift#794).
This commit just catches up the supported-version set, to avoid
failing like [1]:

  $ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_cincinnati-operator/176/pull-ci-openshift-cincinnati-operator-master-operator-e2e-hypershift-local-graph-data/1722001220597452800/artifacts/operator-e2e-hypershift-local-graph-data/e2e-test/artifacts/inspect/namespaces/openshift-updateservice/pods/example-5cd78cdf8b-vqcgv/graph-builder/graph-builder/logs/current.log | tail -n3
  2023-11-07T21:50:33.646877602Z [2023-11-07T21:50:33Z TRACE cincinnati::plugins] Running next plugin 'openshift-secondary-metadata-parse'
  2023-11-07T21:50:33.657154577Z [2023-11-07T21:50:33Z ERROR graph_builder::graph] unrecognized graph-data version 1.2.0
  2023-11-07T21:50:33.657154577Z     ; supported versions: ["1.0.0", "1.1.0"]

when run against graph-data that declares itself to use the new
version.

[1]: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cincinnati-operator/176/pull-ci-openshift-cincinnati-operator-master-operator-e2e-hypershift-local-graph-data/1722001220597452800
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 7, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 7, 2023

@wking: This pull request references OTA-946 which is a valid jira issue.

Details

In response to this:

openshift/cincinnati-graph-data@9e9e97cf2a (openshift/cincinnati-graph-data#3509) defined that graph-data version, adding only:

signatures/{algorithm}/{digest}/signature-{number}

Cincinnati learned how to process those paths already in fb20669 (#794) and #816. This commit just catches up the supported-version set, to avoid failing like:

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_cincinnati-operator/176/pull-ci-openshift-cincinnati-operator-master-operator-e2e-hypershift-local-graph-data/1722001220597452800/artifacts/operator-e2e-hypershift-local-graph-data/e2e-test/artifacts/inspect/namespaces/openshift-updateservice/pods/example-5cd78cdf8b-vqcgv/graph-builder/graph-builder/logs/current.log | tail -n3
2023-11-07T21:50:33.646877602Z [2023-11-07T21:50:33Z TRACE cincinnati::plugins] Running next plugin 'openshift-secondary-metadata-parse'
2023-11-07T21:50:33.657154577Z [2023-11-07T21:50:33Z ERROR graph_builder::graph] unrecognized graph-data version 1.2.0
2023-11-07T21:50:33.657154577Z     ; supported versions: ["1.0.0", "1.1.0"]

when run against graph-data that declares itself to use the new version.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2023
wking added a commit to wking/cincinnati-operator that referenced this pull request Nov 7, 2023
To avoid tripping over an overly strict graph-data parser until [1]
lands.

[1]: openshift/cincinnati#876
wking added a commit to wking/cincinnati-operator that referenced this pull request Nov 7, 2023
To avoid tripping over an overly strict graph-data parser until [1]
lands.

[1]: openshift/cincinnati#876
@wking
Copy link
Member Author

wking commented Nov 7, 2023

unable to find the 'cli' image is a build-cluster flake.

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 7, 2023

@wking: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

wking added a commit to wking/cincinnati-operator that referenced this pull request Nov 7, 2023
To avoid tripping over an overly strict graph-data parser until [1]
lands.

[1]: openshift/cincinnati#876
wking added a commit to wking/cincinnati-operator that referenced this pull request Nov 8, 2023
To avoid tripping over an overly strict graph-data parser until [1]
lands.

[1]: openshift/cincinnati#876
Copy link
Contributor

@PratikMahajan PratikMahajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PratikMahajan, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [PratikMahajan,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4c05864 into openshift:master Nov 8, 2023
@wking wking deleted the support-graph-data-1.2.0 branch November 8, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants