Skip to content

graph-builder: instrument and expose graph metrics #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 7 commits into from
Mar 15, 2019
Merged

graph-builder: instrument and expose graph metrics #72

openshift-merge-robot merged 7 commits into from
Mar 15, 2019

Conversation

@lucab
Copy link
Contributor

@lucab lucab commented Mar 14, 2019 •
edited
Loading

This adds a status service to serve graph-builder /metrics endpoint.
It is initially hardcoded to bind to 0.0.0.0:9080 (pending configuration rework).
It also adds initial instrumentation to record basic metrics about incoming
requests, total and failed scrapes, fetched releases, and nodes recorded in the
processed DAG.

Ref: https://jira.coreos.com/browse/CORS-1015
/cc @steveej

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 14, 2019
@lucab
graph-builder: add a status service for metrics
e9e3f99 
This adds an initial status service to serve the `/metrics` endpoint.
It is initially hardcoded to bind to 0.0.0.0:9080 (pending
configuration rework).
steveej
steveej suggested changes Mar 14, 2019
View reviewed changes
Copy link
Contributor

@steveej steveej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Some suggestions around naming of the metrics.
  • For the initial metrics we should also have an error counter for failed requests to the upstream.
  • Optionally you could explore counting plugin errors, but I'm fine deferring that

@lucab
Copy link
Contributor Author

lucab commented Mar 14, 2019

Ack on the renaming part.
I'm leaving the error counting out of this as I'm waiting for some offline feedback on the suggested way to record positive/negative scrapes in an aggregable way (but I don't have a clear ETA right now).

@lucab
Copy link
Contributor Author

lucab commented Mar 15, 2019

I got the feedback I was looking for (thanks @mxinden!), so I also added metrics for total and failed scrapes.

@lucab
Copy link
Contributor Author

lucab commented Mar 15, 2019

@steveej I've amended them to upstream_raw_releases and final_releases.

@lucab lucab requested a review from steveej March 15, 2019 14:29
steveej
steveej suggested changes Mar 15, 2019
View reviewed changes
Copy link
Contributor

@steveej steveej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one mismatching description to fix before this is good to go 🙌

@lucab
graph-builder: instrument with initial graph metrics
630d107 
This adds some initial instrumentation to record basic metrics about
incoming requests, total and failed scrapes, fetched releases, and
nodes recorded in the processed DAG.
@lucab
Copy link
Contributor Author

lucab commented Mar 15, 2019

@steveej good catch! Amended.

@lucab lucab requested a review from steveej March 15, 2019 15:13
@steveej
Copy link
Contributor

steveej commented Mar 15, 2019 •
edited
Loading

Thanks!

/lgtm

Unsolicited reminder: please don't forget to make this address and port configurable in #69.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 15, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lucab, steveeJ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit febecb7 into openshift:master Mar 15, 2019
mxinden
mxinden reviewed Mar 16, 2019
View reviewed changes
Copy link

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit late, but this looks good to me. Happy to see more components instrumented!

@lucab lucab mentioned this pull request Mar 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steveej steveej Awaiting requested review from steveej

1 more reviewer

@mxinden mxinden mxinden left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@steveej steveej

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lucab @steveej @openshift-ci-robot @mxinden @openshift-merge-robot