introduce asynchronous plugin processing #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
size/L
Contributor
openshift-ci-robot
added
size/XL
steveej
force-pushed
the
pr/async-plugins
branch
5 times, most recently
from
42e14f2 to
f18e5e2
Compare
openshift-ci-robot
added
size/XXL
steveej
force-pushed
the
pr/async-plugins
branch
5 times, most recently
from
460319b to
6786a85
Compare
7 tasks
steveej
changed the title
steveej
changed the title
lucab
reviewed
Aug 16, 2019
steveej
force-pushed
the
pr/async-plugins
branch
from
6786a85 to
0dd9e09
Compare
openshift-ci-robot
added
the
needs-rebase
steveej
force-pushed
the
pr/async-plugins
branch
from
0dd9e09 to
f20b2df
Compare
steveej
force-pushed
the
pr/async-plugins
branch
from
f20b2df to
80d2b4b
Compare
openshift-ci-robot
removed
the
needs-rebase
steveej
force-pushed
the
pr/async-plugins
branch
2 times, most recently
from
d9584c7 to
e573f86
Compare
Contributor
Author
I compared the alternatives and I think we would get away with the |
lucab
reviewed
Aug 20, 2019
cincinnati/src/plugins/mod.rs
Outdated
| let future_result = futures::stream::iter_ok::<_, Error>(plugins) | ||
| .fold(initial_io, |io, next_plugin| next_plugin.run(io)) | ||
| .into_future() | ||
| // .flatten() |
A symptom of using an asynchronous API throughout the the whole processing chain is that the configured plugin collection must provide static references, so that the references are guaranteed to be valid for the whole lifetime of the program. Changeset * Implement the async interface and enhance its tests * Port the channel-filter * Port the quay metadata plugin * Port edge_add_remove * Port node_remove to async * Port external web plugin example * Adapt the graph-builder * Adapt the policy-engine
steveej
force-pushed
the
pr/async-plugins
branch
from
e573f86 to
2775f48
Compare
Contributor
Author
|
@lucab thanks for another review, comments addressed! PTAL |
1 task
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lucab, steveeJ The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
agree on the approach (the consumption and double-boxing of plugins for processing).allow mutable access to plugins for in-memory persistent plugin-state throughout the lifetime of the daemons. prefer a lock-frree read-only processing implementation and make the plugin responsible for handling their state via interior mutable fields.discussplugin initialization in graph-builder. [WIP] graph-builder: add dynamic plugins configuration #74 can be merged after this one.Box::leakvslazy_static!