Migrate controller to use function SetupWithManager #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
Contributor
Author
|
Not sure why deployment error is popping up now so will retry: /test operator-e2e |
Contributor
Author
|
Works locally but took ~7 minutes for operand deployment to be ready so perhaps it was too slow in coming up in Ci env. |
wking
reviewed
Nov 13, 2020
Contributor
Author
|
/test operator-e2e |
Contributor
Author
|
Have an issue to fix causing test failure /hold |
openshift-ci-robot
added
the
do-not-merge/hold
Member
We should be pulling that from the CI registry... |
wking
added a commit
to wking/cincinnati-operator
that referenced
this pull request
Nov 16, 2020
The outgoing docker.io image was subject to docker.io rate limiting [1]: error: build error: failed to pull image: After retrying 2 times, Pull image still failed due to error: while pulling "docker://docker.io/openshift/origin-release:golang-1.13" as "docker.io/openshift/origin-release:golang-1.13"... The new image matches openshift/cluster-version-operator@7cb2662924 (Updating cluster-version-operator builder & base images to be consistent with ART, 2020-10-07, openshift/cluster-version-operator#468). Matching builders with the CVO reduces our exposure by consolidating around a smaller set of Go builder images. [1]: openshift#82 (comment)
wking
added a commit
to wking/cincinnati-operator
that referenced
this pull request
Nov 16, 2020
The outgoing docker.io image was subject to docker.io rate limiting [1]: error: build error: failed to pull image: After retrying 2 times, Pull image still failed due to error: while pulling "docker://docker.io/openshift/origin-release:golang-1.13" as "docker.io/openshift/origin-release:golang-1.13"... The new image matches openshift/cluster-version-operator@7cb2662924 (Updating cluster-version-operator builder & base images to be consistent with ART, 2020-10-07, openshift/cluster-version-operator#468). Matching builders with the CVO reduces our exposure by consolidating around a smaller set of Go builder images. I expect that after this lands, openshift/registry will pick it up via a change like openshift/release@d0fa1c98b9 (Registry-replacer autocommit, 2020-10-07, openshift/release#12532). [1]: openshift#82 (comment)
Member
|
Needs a rebase as #86 is merged now. |
Supported legacy leader.Become method required operator-lib dependency.
jottofar
force-pushed
the
controller-migrate
branch
from
7122c12 to
56104f6
Compare
jottofar
force-pushed
the
controller-migrate
branch
from
56104f6 to
5caf9dc
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jottofar, LalatenduMohanty The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/unhold |
openshift-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was not originally done in the migration to operator-sdk v0.19.3. In that original migration I choose to continue using the legacy leader election method, which is still supported, and was not sure how to do so while also using SetupWithManager. This PR migrates leader election to the controller-runtime’s leader with lease mechanism as well.
Also added back in a couple of kubebuilder:scaffold markers which shouldn't have been deleted