functests: Add set up method to add schemes #74
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
wking
force-pushed
the
route-scheme-fix
branch
from
9622f29 to
fdc9892
Compare
/retest |
|
/test operator-e2e |
|
e2e: $ oc --context build01 delete project ci-op-nhr8xycy/retest |
|
All green :). /assign @jottofar |
|
|
||
| // setUp performs test setup. | ||
| func setUp() { | ||
| if err := routev1.AddToScheme(scheme.Scheme); err != nil { |
There was a problem hiding this comment.
Is there a reason you dropped this?
There was a problem hiding this comment.
Yeah, we don't import that yet. We can add it with the commit that adds the import
There was a problem hiding this comment.
But you're just adding back stuff that shouldn't have been removed to begin with. I should have caught it and commented in in the Remove Ginkgp commit so not understanding why this commit doen't just add it all back in.
There was a problem hiding this comment.
We used to add the route scheme (twice?). And out local APIs, which you link. I dunno why we don't actually need the local-API schemes injected, but tests are green, so we must not need them.
|
/lgtm |
raw/metadata.json: add historical metadata from quay
4 participants
Pulled out of #65, since this should green up CI and seems orthogonal to the SDK pivot.