functests: Drop Ginkgo dependency

[wking]

Use Go's built-in testing package instead. This avoids issues like:

Retrieving ginkgo and gomega build dependencies
go: github.com/openshift/cluster-image-registry-operator@v0.0.0-20200415091009-99c06ee64540 requires
		github.com/openshift/library-go@v0.0.0-20200327125526-163b2f0d6264 requires
		bitbucket.org/ww/goautoneg@v0.0.0-20120707110453-75cd24fc2f2c: reading https://api.bitbucket.org/2.0/repositories/ww/goautoneg?fields=scm: 404 Not Found
go: github.com/openshift/cluster-image-registry-operator@v0.0.0-20200415091009-99c06ee64540 requires
		github.com/openshift/library-go@v0.0.0-20200327125526-163b2f0d6264 requires
		bitbucket.org/ww/goautoneg@v0.0.0-20120707110453-75cd24fc2f2c: reading https://api.bitbucket.org/2.0/repositories/ww/goautoneg?fields=scm: 404 Not Found
hack/functest.sh: line 17: /go/bin/ginkgo: No such file or directory
hack/functest.sh: line 19: /go/bin/ginkgo: No such file or directory

The tests are simple enough that Ginkgo structuring was overkill anyway. Generated by manually editing files in functests, and then running:

$ go mod tidy
$ go mod vendor
$ git add -A go.* vendor

using:

$ go version
go version go1.15.2 linux/amd64

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[wking]

e2e:

I1019 23:14:32.267387    4738 utils.go:121] Waiting for full availability of cincinnati-operator deployment (0/1)
panic: test timed out after 10m0s

Because:

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_cincinnati-operator/69/pull-ci-openshift-cincinnati-operator-master-cincinnati-operator-e2e-aws/1318318319090012160/artifacts/cincinnati-operator-e2e-aws/pods.json | jq -r '.items[] | select(.metadata.name | startswith("cincinnati-operator-")).status.containerStatuses[].state'
{
  "waiting": {
    "message": "Back-off pulling image \"registry.svc.ci.openshift.org/ci-op-9s6krr21/stable:cincinnati-operator\"",
    "reason": "ImagePullBackOff"
  }
}

Dunno what to do about that...

[jottofar]

You're where I'm at now I believe.

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_cincinnati-operator/69/pull-ci-openshift-cincinnati-operator-master-cincinnati-operator-e2e-aws/1318318319090012160/artifacts/cincinnati-operator-e2e-aws/events.json:
"message": "Back-off pulling image "registry.svc.ci.openshift.org/ci-op-9s6krr21/stable:cincinnati-operator""

Which according to our thread https://coreos.slack.com/archives/CBN38N3MW/p1603125539363800 is due to a need to use dependencies and therefore a need to get your multi-step PR merged.

[wking]

I'm more confident in this change vs. the release one. Can we /override ... here to get the more meaningful rehearsals there?

[wking]

/override ci/prow/cincinnati-operator-e2e-aws

Assume this is ok, so we can work on rehearsals in openshift/release#12486.

[openshift-ci-robot]

@wking: Overrode contexts on behalf of wking: ci/prow/cincinnati-operator-e2e-aws

Details

In response to this:

/override ci/prow/cincinnati-operator-e2e-aws

Assume this is ok, so we can work on rehearsals in openshift/release#12486.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jottofar]

/lgtm