-
Notifications
You must be signed in to change notification settings - Fork 32
Migrate OSUS operator from v0.18.2 to v1.0 #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
fa3e8b7
d9f361a
ce9a447
f938f3f
71d0959
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| FROM docker.io/openshift/origin-release:golang-1.13 AS builder | ||
| WORKDIR /go/src/github.com/openshift/cincinnati-operator/ | ||
| COPY . . | ||
| RUN go build -mod=vendor -o /tmp/build/cincinnati-operator github.com/openshift/cincinnati-operator/cmd/manager | ||
| RUN go build -mod=vendor -o /tmp/build/updateservice-operator github.com/openshift/cincinnati-operator | ||
|
|
||
| FROM registry.access.redhat.com/ubi8/ubi-minimal:latest | ||
|
|
||
| COPY --from=builder /tmp/build/cincinnati-operator /usr/bin/cincinnati-operator | ||
| ENTRYPOINT ["/usr/bin/cincinnati-operator"] | ||
| COPY --from=builder /tmp/build/updateservice-operator /usr/bin/updateservice-operator | ||
| ENTRYPOINT ["/usr/bin/updateservice-operator"] | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| domain: openshift.io | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You split
So I suspect we want an
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I based the group name on what we decided on in https://issues.redhat.com/browse/OTA-258 which was updateservice.operator. I specifically tested this out first with a generate as well before committing to it and it did cause any issues. |
||
| layout: go.kubebuilder.io/v2 | ||
| repo: github.com/openshift/cincinnati-operator | ||
| resources: | ||
| - group: updateservice.operator | ||
| kind: UpdateService | ||
| version: v1 | ||
| version: 3-alpha | ||
| projectName: updateservice-operator | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In #79 I've gone with
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can change this as well afterwards if we want. |
||
| plugins: | ||
| go.sdk.operatorframework.io/v2-alpha: {} | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| // Package v1 contains API Schema definitions for the updateservice v1 API group | ||
| // +kubebuilder:object:generate=true | ||
| // +groupName=updateservice.operator.openshift.io | ||
| package v1 | ||
|
|
||
| import ( | ||
| "k8s.io/apimachinery/pkg/runtime/schema" | ||
| "sigs.k8s.io/controller-runtime/pkg/scheme" | ||
| ) | ||
|
|
||
| var ( | ||
| // GroupVersion is group version used to register these objects | ||
| GroupVersion = schema.GroupVersion{Group: "updateservice.operator.openshift.io", Version: "v1"} | ||
|
|
||
| // SchemeBuilder is used to add go types to the GroupVersionKind scheme | ||
| SchemeBuilder = &scheme.Builder{GroupVersion: GroupVersion} | ||
|
|
||
| // AddToScheme adds the types in this group-version to the given scheme. | ||
| AddToScheme = SchemeBuilder.AddToScheme | ||
| ) |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No external consumers, so we can always change this post-pivot, but in #78 I used
update-service-operatorinstead ofupdateservice-operatoras the binary name.