pkg/apis/cincinnati/v1beta1: Drop redundant doc.go #57
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wking The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
We've had a package docstring in both doc.go and register.go since v1alpha1 in 52a9765 (first code commit, 2020-04-03, openshift#1). But there's no reason to have a doc.go declaration when register.go already defines the same material. Also add a trailing period to the docstring sentence and capitalize the Cincinnati proper noun. And remove the boilerplate comment, because this is a hand-maintained file, even if changes will be rare.
wking
force-pushed
the
drop-redundant-api-doc-file
branch
from
e27257b to
bbcaeaa
Compare
|
@wking: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
#65 will clear this up as a side-effect. /close |
|
@wking: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
candidate-4.3: add 4.3.3
2 participants
We've had a package docstring in both doc.go and register.go since v1alpha1 in 52a9765 (#1). But there's no reason to have a
doc.godeclaration whenregister.goalready defines the same material.Also add a trailing period to the docstring sentence and remove the boilerplate comment, because this is a hand-maintained file, even if changes will be rare.