Skip to content

Conversation

@rthallisey
Copy link
Contributor

make build will build will compile a binary.

@rthallisey
Copy link
Contributor Author

/ok-to-test

@openshift-ci-robot openshift-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 4, 2020
@rwsu
Copy link
Contributor

rwsu commented May 5, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2020
@rthallisey
Copy link
Contributor Author

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rthallisey
To complete the pull request process, please assign mhrivnak
You can assign the PR to them by writing /assign @mhrivnak in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

@rthallisey: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2020
@openshift-ci-robot
Copy link

@rthallisey: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/cincinnati-operator-e2e-aws de41f76 link /test cincinnati-operator-e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 13, 2020
@jottofar
Copy link
Contributor

/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 13, 2020
jottofar added a commit to jottofar/cincinnati-operator that referenced this pull request Oct 13, 2020
Reference migration guide
https://master.sdk.operatorframework.io/docs/upgrading-sdk-version/v1.0.0/
for high-level overview of the steps to migrate operator from Operator
SDK v0.19.3 to v1.0.0.

Configured metrics using kustomize-based generation.

Various clean up and rework.

Add build recipe in Makefile (changes from
openshift#33)
@jottofar
Copy link
Contributor

This change has been incorporated into #65.

@jottofar
Copy link
Contributor

/close

@openshift-ci-robot
Copy link

@jottofar: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jottofar added a commit to jottofar/cincinnati-operator that referenced this pull request Oct 13, 2020
Reference migration guide
https://master.sdk.operatorframework.io/docs/upgrading-sdk-version/v1.0.0/
for high-level overview of the steps to migrate operator from Operator
SDK v0.19.3 to v1.0.0.

Configured metrics using kustomize-based generation.

Various clean up and rework.

Add build recipe in Makefile (changes from
openshift#33)
jottofar added a commit to jottofar/cincinnati-operator that referenced this pull request Oct 13, 2020
Reference migration guide
https://master.sdk.operatorframework.io/docs/upgrading-sdk-version/v1.0.0/
for high-level overview of the steps to migrate operator from Operator
SDK v0.19.3 to v1.0.0.

Configured metrics using kustomize-based generation.

Various clean up and rework.

Add build recipe in Makefile (changes from
openshift#33)
jottofar added a commit to jottofar/cincinnati-operator that referenced this pull request Oct 14, 2020
Reference migration guide
https://master.sdk.operatorframework.io/docs/upgrading-sdk-version/v1.0.0/
for high-level overview of the steps to migrate operator from Operator
SDK v0.19.3 to v1.0.0.

Configured metrics using kustomize-based generation.

Various clean up and rework.

Add build recipe in Makefile (changes from
openshift#33)
jottofar added a commit to jottofar/cincinnati-operator that referenced this pull request Oct 14, 2020
Reference migration guide
https://master.sdk.operatorframework.io/docs/upgrading-sdk-version/v1.0.0/
for high-level overview of the steps to migrate operator from Operator
SDK v0.19.3 to v1.0.0.

Configured metrics using kustomize-based generation.

Various clean up and rework.

Add build recipe in Makefile (changes from
openshift#33)
jottofar added a commit to jottofar/cincinnati-operator that referenced this pull request Oct 20, 2020
Reference migration guide
https://master.sdk.operatorframework.io/docs/upgrading-sdk-version/v1.0.0/
for high-level overview of the steps to migrate operator from Operator
SDK v0.19.3 to v1.0.0.

Configured metrics using kustomize-based generation.

Various clean up and rework.

Add build recipe in Makefile (changes from
openshift#33)
jottofar added a commit to jottofar/cincinnati-operator that referenced this pull request Oct 22, 2020
Reference migration guide
https://master.sdk.operatorframework.io/docs/upgrading-sdk-version/v1.0.0/
for high-level overview of the steps to migrate operator from Operator
SDK v0.19.3 to v1.0.0.

Configured metrics using kustomize-based generation.

Various clean up and rework.

Add build recipe in Makefile (changes from
openshift#33)
jottofar added a commit to jottofar/cincinnati-operator that referenced this pull request Oct 22, 2020
Reference migration guide
https://master.sdk.operatorframework.io/docs/upgrading-sdk-version/v1.0.0/
for high-level overview of the steps to migrate operator from Operator
SDK v0.19.3 to v1.0.0.

Configured metrics using kustomize-based generation.

Various clean up and rework.

Add build recipe in Makefile (changes from
openshift#33)
jottofar added a commit to jottofar/cincinnati-operator that referenced this pull request Oct 24, 2020
Reference migration guide
https://master.sdk.operatorframework.io/docs/upgrading-sdk-version/v1.0.0/
for high-level overview of the steps to migrate operator from Operator
SDK v0.19.3 to v1.0.0.

Configured metrics using kustomize-based generation.

Various clean up and rework.

Add build recipe in Makefile (changes from
openshift#33)
jottofar added a commit to jottofar/cincinnati-operator that referenced this pull request Oct 24, 2020
Reference migration guide
https://master.sdk.operatorframework.io/docs/upgrading-sdk-version/v1.0.0/
for high-level overview of the steps to migrate operator from Operator
SDK v0.19.3 to v1.0.0.

Configured metrics using kustomize-based generation.

Various clean up and rework.

Add build recipe in Makefile (changes from
openshift#33)
jottofar added a commit to jottofar/cincinnati-operator that referenced this pull request Oct 26, 2020
Reference migration guide
https://master.sdk.operatorframework.io/docs/upgrading-sdk-version/v1.0.0/
for high-level overview of the steps to migrate operator from Operator
SDK v0.19.3 to v1.0.0.

Configured metrics using kustomize-based generation.

Various clean up and rework.

Add build recipe in Makefile (changes from
openshift#33)
jottofar added a commit to jottofar/cincinnati-operator that referenced this pull request Oct 27, 2020
Reference migration guide
https://master.sdk.operatorframework.io/docs/upgrading-sdk-version/v1.0.0/
for high-level overview of the steps to migrate operator from Operator
SDK v0.19.3 to v1.0.0.

Configured metrics using kustomize-based generation.

Various clean up and rework.

Add build recipe in Makefile (changes from
openshift#33)
jottofar added a commit to jottofar/cincinnati-operator that referenced this pull request Oct 27, 2020
Reference migration guide
https://master.sdk.operatorframework.io/docs/upgrading-sdk-version/v1.0.0/
for high-level overview of the steps to migrate operator from Operator
SDK v0.19.3 to v1.0.0.

Configured metrics using kustomize-based generation.

Various clean up and rework.

Add build recipe in Makefile (changes from
openshift#33)
jottofar added a commit to jottofar/cincinnati-operator that referenced this pull request Oct 28, 2020
Reference migration guide
https://master.sdk.operatorframework.io/docs/upgrading-sdk-version/v1.0.0/
for high-level overview of the steps to migrate operator from Operator
SDK v0.19.3 to v1.0.0.

Configured metrics using kustomize-based generation.

Various clean up and rework.

Add build recipe in Makefile (changes from
openshift#33)
jottofar added a commit to jottofar/cincinnati-operator that referenced this pull request Oct 28, 2020
Reference migration guide
https://master.sdk.operatorframework.io/docs/upgrading-sdk-version/v1.0.0/
for high-level overview of the steps to migrate operator from Operator
SDK v0.19.3 to v1.0.0.

Configured metrics using kustomize-based generation.

Various clean up and rework.

Add build recipe in Makefile (changes from
openshift#33)
jottofar added a commit to jottofar/cincinnati-operator that referenced this pull request Oct 28, 2020
Reference migration guide
https://master.sdk.operatorframework.io/docs/upgrading-sdk-version/v1.0.0/
for high-level overview of the steps to migrate operator from Operator
SDK v0.19.3 to v1.0.0.

Configured metrics using kustomize-based generation.

Various clean up and rework.

Add build recipe in Makefile (changes from
openshift#33)
jottofar added a commit to jottofar/cincinnati-operator that referenced this pull request Oct 28, 2020
Reference migration guide
https://master.sdk.operatorframework.io/docs/upgrading-sdk-version/v1.0.0/
for high-level overview of the steps to migrate operator from Operator
SDK v0.19.3 to v1.0.0.

Configured metrics using kustomize-based generation.

Various clean up and rework.

Add build recipe in Makefile (changes from
openshift#33)
jottofar added a commit to jottofar/cincinnati-operator that referenced this pull request Oct 28, 2020
Reference migration guide
https://master.sdk.operatorframework.io/docs/upgrading-sdk-version/v1.0.0/
for high-level overview of the steps to migrate operator from Operator
SDK v0.19.3 to v1.0.0.

Configured metrics using kustomize-based generation.

Various clean up and rework.

Add build recipe in Makefile (changes from
openshift#33)
jottofar added a commit to jottofar/cincinnati-operator that referenced this pull request Oct 30, 2020
Reference migration guide
https://master.sdk.operatorframework.io/docs/upgrading-sdk-version/v1.0.0/
for high-level overview of the steps to migrate operator from Operator
SDK v0.19.3 to v1.0.0.

Configured metrics using kustomize-based generation.

Various clean up and rework.

Add build recipe in Makefile (changes from
openshift#33)
jottofar added a commit to jottofar/cincinnati-operator that referenced this pull request Nov 2, 2020
Reference migration guide
https://master.sdk.operatorframework.io/docs/upgrading-sdk-version/v1.0.0/
for high-level overview of the steps to migrate operator from Operator
SDK v0.19.3 to v1.0.0.

Configured metrics using kustomize-based generation.

Various clean up and rework.

Add build recipe in Makefile (changes from
openshift#33)
jottofar added a commit to jottofar/cincinnati-operator that referenced this pull request Nov 11, 2020
Reference migration guide
https://master.sdk.operatorframework.io/docs/upgrading-sdk-version/v1.0.0/
for high-level overview of the steps to migrate operator from Operator
SDK v0.19.3 to v1.0.0.

Configured metrics using kustomize-based generation.

Various clean up and rework.

Add build recipe in Makefile (changes from
openshift#33)
jottofar added a commit to jottofar/cincinnati-operator that referenced this pull request Nov 11, 2020
Reference migration guide
https://master.sdk.operatorframework.io/docs/upgrading-sdk-version/v1.0.0/
for high-level overview of the steps to migrate operator from Operator
SDK v0.19.3 to v1.0.0.

Configured metrics using kustomize-based generation.

Various clean up and rework.

Add build recipe in Makefile (changes from
openshift#33)
jottofar added a commit to jottofar/cincinnati-operator that referenced this pull request Nov 12, 2020
Reference migration guide
https://master.sdk.operatorframework.io/docs/upgrading-sdk-version/v1.0.0/
for high-level overview of the steps to migrate operator from Operator
SDK v0.19.3 to v1.0.0.

Configured metrics using kustomize-based generation.

Various clean up and rework.

Add build recipe in Makefile (changes from
openshift#33)
jottofar added a commit to jottofar/cincinnati-operator that referenced this pull request Nov 12, 2020
Reference migration guide
https://master.sdk.operatorframework.io/docs/upgrading-sdk-version/v1.0.0/
for high-level overview of the steps to migrate operator from Operator
SDK v0.19.3 to v1.0.0.

Configured metrics using kustomize-based generation.

Various clean up and rework.

Add build recipe in Makefile (changes from
openshift#33)
PratikMahajan pushed a commit to PratikMahajan/cincinnati-operator that referenced this pull request Mar 17, 2021
channels/*-4.2: Explain why we skipped 4.2.15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants